linux-kernel - Re: [PATCH] EDAC/amd64: Do not load EDAC driver when running as a guest

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAMGffEm1ZX1bRJXTbMj=acV+URSMmKXM_Pohq2Cwi4p1osDdgQ@mail.gmail.com>
Date:   Tue, 6 Jul 2021 07:38:41 +0200
From:   Jinpu Wang <jinpu.wang@...os.com>
To:     Borislav Petkov <bp@...en8.de>
Cc:     linux-edac@...r.kernel.org, yazen.ghannam@....com,
        "Luck, Tony" <tony.luck@...el.com>, mchehab@...nel.org,
        open list <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] EDAC/amd64: Do not load EDAC driver when running as a guest

On Tue, Jul 6, 2021 at 7:34 AM Borislav Petkov <bp@...en8.de> wrote:
>
> On Tue, Jul 06, 2021 at 07:08:33AM +0200, Jack Wang wrote:
> > Similar to commit f0a029fff4a5 ("EDAC/Intel: Do not load EDAC driver when running as a guest")
> >
> > There's little to no point in loading an EDAC driver running in a guest.
> >
> > Add a check in each of the Intel EDAC drivers for X86_FEATURE_HYPERVISOR
> > and simply return -ENODEV in the init routine.
>
> Did you even read this sentence before leaving it in the commit message
> or you simply copied the commit message of f0a029fff4a5 blindly?
sorry, I notice the patch for Intel, and feel we should do the same
for AMD, hence post the patch.
I forgot to adapt the content of the commit message. -.-
>
> Also:
>
> https://lore.kernel.org/linux-edac/20210628172740.245689-1-Smita.KoralahalliChannabasappa@amd.com/
>
Great if it's already in the queue.
> --
> Regards/Gruss,
>     Boris.
>
> https://people.kernel.org/tglx/notes-about-netiquette
Thanks!