linux-kernel - Re: [PATCH] x86/PCI: Handle PIRQ routing tables with no router device given

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <alpine.DEB.2.21.2107061330490.1711@angie.orcam.me.uk>
Date:   Tue, 6 Jul 2021 13:35:39 +0200 (CEST)
From:   "Maciej W. Rozycki" <macro@...am.me.uk>
To:     Nikolai Zhubr <zhubr.2@...il.com>
cc:     Bjorn Helgaas <bhelgaas@...gle.com>,
        Thomas Gleixner <tglx@...utronix.de>,
        Ingo Molnar <mingo@...hat.com>, Borislav Petkov <bp@...en8.de>,
        "H. Peter Anvin" <hpa@...or.com>, Arnd Bergmann <arnd@...nel.org>,
        x86@...nel.org, linux-pci@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] x86/PCI: Handle PIRQ routing tables with no router device
 given

Hello Nikolai,

> > PIRQ routing tables provided by the PCI BIOS usually specify the PCI
> > vendor:device ID as well as the bus address of the device implementing
> > the PIRQ router, e.g.:
> [...]
> > linux-x86-pirq-router-nodev.diff
> 
> This one throws a panic in bus_find_device() here.
> I can not yet get a good printout because scrollback does not work.
> Maybe it is because of 4.14 kernel, and in order to apply it I had to change
> pci_get_domain_bus_and_slot back to pci_get_bus_and_slot.
> I'll try to also test with 5.x kernel later today.

 Umm, my bad; I missed the initialisation of `dev' for `for_each_pci_dev'.  
I have posted v2, with another `dev'-related fix as well.  Please try that 
instead, and sorry for the mess-up.

  Maciej