[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date: Wed, 7 Jul 2021 17:21:28 +0800
From: "huangguangbin (A)" <huangguangbin2@...wei.com>
To: Jakub Kicinski <kuba@...nel.org>
CC: <davem@...emloft.net>, <jiri@...dia.com>, <netdev@...r.kernel.org>,
<linux-kernel@...r.kernel.org>, <lipeng321@...wei.com>,
<chenhao288@...ilicon.com>
Subject: Re: [RFC PATCH net-next 3/8] net: hns3: add support for devlink get
info for PF
On 2021/7/7 7:14, Jakub Kicinski wrote:
> On Tue, 6 Jul 2021 14:41:27 +0800 Guangbin Huang wrote:
>> + return devlink_info_version_running_put(req, "fw-version", version_str);
>
> Please use one of the existing names instead of "fw-version",
> e.g. DEVLINK_INFO_VERSION_GENERIC_FW.
> .
>
Ok, thanks.
Powered by blists - more mailing lists