[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date: Wed, 7 Jul 2021 17:17:30 +0100
From: Mark Brown <broonie@...nel.org>
To: Vijendar Mukunda <vijendar.mukunda@....com>
Cc: alsa-devel@...a-project.org, Alexander.Deucher@....com,
Sunil-kumar.Dommati@....com, Liam Girdwood <lgirdwood@...il.com>,
Jaroslav Kysela <perex@...ex.cz>,
Takashi Iwai <tiwai@...e.com>,
open list <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 02/12] ASoC: amd: add Vangogh ACP PCI driver
On Wed, Jul 07, 2021 at 11:26:13AM +0530, Vijendar Mukunda wrote:
> +static inline u32 acp_readl(void __iomem *base_addr)
> +{
> + return readl(base_addr - ACP5x_PHY_BASE_ADDRESS);
> +}
I see this was the same for Renoir but it's weird that the read and
write functions are substracting rather than adding the base address
here. A comment might be good.
Download attachment "signature.asc" of type "application/pgp-signature" (489 bytes)
Powered by blists - more mailing lists