[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date: Wed, 7 Jul 2021 10:23:35 -0700
From: Linus Torvalds <torvalds@...ux-foundation.org>
To: Alexey Gladkov <legion@...nel.org>
Cc: "Eric W. Biederman" <ebiederm@...ssion.com>,
Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
Linux Containers <containers@...ts.linux.dev>
Subject: Re: [PATCH] ucounts: Fix UCOUNT_RLIMIT_SIGPENDING counter leak
On Wed, Jul 7, 2021 at 9:50 AM Alexey Gladkov <legion@...nel.org> wrote:
>
> > + dec_rlimit_ucounts(ucounts, UCOUNT_RLIMIT_SIGPENDING, 1);
> > + fallthrough;
> > + case LONG_MAX:
>
> I think that the counter should be decreased in this case too.
> inc_rlimit_ucounts() increments the counter in all parent userns. If we
> don't decrease the counter then the parent userns will have a counter
> leak.
Ack. So basically that patch, but move the dec_rlimit_ucounts() into
the LONG_MAX case?
Would you mind making a real patch with a commit message, and trying
whatever test-case you had for that KASAN use-after-free report?
Linus
Powered by blists - more mailing lists