linux-kernel - Re: [PATCH RFC 0/2] driver core: Add ability to delete device links of unregistered devices

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Wed, 7 Jul 2021 10:41:48 -0700
From:   Saravana Kannan <saravanak@...gle.com>
To:     Greg Kroah-Hartman <gregkh@...uxfoundation.org>
Cc:     Adrian Hunter <adrian.hunter@...el.com>,
        "Rafael J . Wysocki" <rafael@...nel.org>,
        "Martin K . Petersen" <martin.petersen@...cle.com>,
        "James E . J . Bottomley" <jejb@...ux.ibm.com>,
        linux-scsi@...r.kernel.org, Avri Altman <avri.altman@....com>,
        Bean Huo <huobean@...il.com>, Can Guo <cang@...eaurora.org>,
        Asutosh Das <asutoshd@...eaurora.org>,
        Bart Van Assche <bvanassche@....org>,
        linux-pm@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH RFC 0/2] driver core: Add ability to delete device links
 of unregistered devices

On Wed, Jul 7, 2021 at 10:40 AM Greg Kroah-Hartman
<gregkh@...uxfoundation.org> wrote:
>
> On Wed, Jul 07, 2021 at 08:29:46PM +0300, Adrian Hunter wrote:
> > Hi
> >
> > There is an issue with the SCSI UFS driver when the optional
> > BOOT well-known LUN fails to probe, which is not a fatal error.
> > The issue is that the device and its "managed" device link do not
> > then get deleted.  The device because the device link has a
> > reference to it.  The device link because it can only be deleted
> > by device_del(), but device_add() was never called, so device_del()
> > never will be either.
>
> How was a link created for something that never had device_add() called
> on it?  Who is doing that?
>

Greg responded as I was typing :)

Nak for the series. I don't like mixing and matching the control of
managed device links like this.

Can I get more details please. How is the device link added in the first place?

-Saravana