linux-kernel - Re: [PATCH v4] tty: serial: jsm: allocate queue buffer at probe time

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Wed, 7 Jul 2021 21:13:13 +0200
From:   Jiri Slaby <jirislaby@...nel.org>
To:     Andy Shevchenko <andy.shevchenko@...il.com>
Cc:     Zheyu Ma <zheyuma97@...il.com>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        "open list:SERIAL DRIVERS" <linux-serial@...r.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v4] tty: serial: jsm: allocate queue buffer at probe time

On 07. 07. 21, 14:52, Andy Shevchenko wrote:
> On Wed, Jul 7, 2021 at 10:50 AM Jiri Slaby <jirislaby@...nel.org> wrote:
>> On 05. 07. 21, 14:53, Zheyu Ma wrote:
> 
>> So how it comes an interrupt came before
>> neo_param() in jsm_tty_open was called?
> 
> If IRQ is shared we have a special debug feature to test shared IRQs
> on freeing IRQ stage (*).
> But it doesn't matter, the IRQ handler must survive at any stage after
> the action has been listed.

Yes, but IRQ_NONE is returned from the ISR in that case.

The issue the patch is fixing is for a "malicious" device and I am not 
sure we want to fix this -- if I can put in a malicious device, I can 
use hammer to kill the box too…

thanks,
-- 
js