linux-kernel - Re: [PATCH] tools: bpf: Fix error in 'make -C tools/ bpf

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Wed, 7 Jul 2021 14:09:11 -0700
From:   Andrii Nakryiko <andrii.nakryiko@...il.com>
To:     Wei Li <liwei391@...wei.com>
Cc:     Alexei Starovoitov <ast@...nel.org>,
        Daniel Borkmann <daniel@...earbox.net>,
        Andrii Nakryiko <andrii@...nel.org>,
        Martin KaFai Lau <kafai@...com>,
        Song Liu <songliubraving@...com>, Yonghong Song <yhs@...com>,
        John Fastabend <john.fastabend@...il.com>,
        KP Singh <kpsingh@...nel.org>, bpf <bpf@...r.kernel.org>,
        open list <linux-kernel@...r.kernel.org>,
        huawei.libin@...wei.com
Subject: Re: [PATCH] tools: bpf: Fix error in 'make -C tools/ bpf_install'

On Sun, Jun 27, 2021 at 8:05 PM Wei Li <liwei391@...wei.com> wrote:
>
> make[2]: *** No rule to make target 'install'.  Stop.
> make[1]: *** [Makefile:122: runqslower_install] Error 2
> make: *** [Makefile:116: bpf_install] Error 2
>
> There is no rule for target 'install' in tools/bpf/runqslower/Makefile,
> and there is no need to install it, so just remove 'runqslower_install'.
>
> Fixes: 9c01546d26d2 ("tools/bpf: Add runqslower tool to tools/bpf")
> Signed-off-by: Wei Li <liwei391@...wei.com>
> ---

Applied to bpf tree, thanks.

Technically runqslower could be installed, but it's better to leave
that to libbpf-tools ([0]), which distributes runqslower along other
BPF-based tools.

  [0] https://github.com/iovisor/bcc/tree/master/libbpf-tools

>  tools/bpf/Makefile | 7 ++-----
>  1 file changed, 2 insertions(+), 5 deletions(-)
>
> diff --git a/tools/bpf/Makefile b/tools/bpf/Makefile
> index 39bb322707b4..b11cfc86a3d0 100644
> --- a/tools/bpf/Makefile
> +++ b/tools/bpf/Makefile
> @@ -97,7 +97,7 @@ clean: bpftool_clean runqslower_clean resolve_btfids_clean
>         $(Q)$(RM) -- $(OUTPUT)FEATURE-DUMP.bpf
>         $(Q)$(RM) -r -- $(OUTPUT)feature
>
> -install: $(PROGS) bpftool_install runqslower_install
> +install: $(PROGS) bpftool_install
>         $(call QUIET_INSTALL, bpf_jit_disasm)
>         $(Q)$(INSTALL) -m 0755 -d $(DESTDIR)$(prefix)/bin
>         $(Q)$(INSTALL) $(OUTPUT)bpf_jit_disasm $(DESTDIR)$(prefix)/bin/bpf_jit_disasm
> @@ -118,9 +118,6 @@ bpftool_clean:
>  runqslower:
>         $(call descend,runqslower)
>
> -runqslower_install:
> -       $(call descend,runqslower,install)
> -
>  runqslower_clean:
>         $(call descend,runqslower,clean)
>
> @@ -131,5 +128,5 @@ resolve_btfids_clean:
>         $(call descend,resolve_btfids,clean)
>
>  .PHONY: all install clean bpftool bpftool_install bpftool_clean \
> -       runqslower runqslower_install runqslower_clean \
> +       runqslower runqslower_clean \
>         resolve_btfids resolve_btfids_clean
> --
> 2.25.1
>