linux-kernel - Re: [PATCH 07/12] ASoC: amd: add ACP5x pcm dma driver ops

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <88def0fa-a792-890f-9a94-7e56ef19497f@amd.com>
Date:   Thu, 8 Jul 2021 17:13:34 +0530
From:   "Mukunda,Vijendar" <vijendar.mukunda@....com>
To:     Mark Brown <broonie@...nel.org>
Cc:     alsa-devel@...a-project.org, Alexander.Deucher@....com,
        Sunil-kumar.Dommati@....com, Liam Girdwood <lgirdwood@...il.com>,
        Jaroslav Kysela <perex@...ex.cz>,
        Takashi Iwai <tiwai@...e.com>,
        open list <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 07/12] ASoC: amd: add ACP5x pcm dma driver ops

On 7/7/21 10:00 PM, Mark Brown wrote:
> On Wed, Jul 07, 2021 at 11:26:18AM +0530, Vijendar Mukunda wrote:
> 
>> +	/* Group Enable */
>> +	acp_writel(ACP_SRAM_PTE_OFFSET | BIT(31), rtd->acp5x_base +
>> +		   ACPAXI2AXI_ATU_BASE_ADDR_GRP_1);
>> +	acp_writel(PAGE_SIZE_4K_ENABLE, rtd->acp5x_base +
>> +		   ACPAXI2AXI_ATU_PAGE_SIZE_GRP_1);
> 
> This isn't connected to the kernel page size is it?  If so we might've
> configured to 16K or 64K, or possibly even some other options - I know
> those two are out there in the wild.
> 
No this is not connected to kernel page size. This is internal to ACP IP.