linux-kernel - Re: [PATCH 0/2] Two mmc fixes for IDA and KASAN issues

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAPDyKFozrrtwOEzBeKctD5fRM=D0dg9N=kFsvdXXDO-zD51Diw@mail.gmail.com>
Date:   Thu, 8 Jul 2021 14:11:44 +0200
From:   Ulf Hansson <ulf.hansson@...aro.org>
To:     Stephen Boyd <swboyd@...omium.org>
Cc:     Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        linux-mmc <linux-mmc@...r.kernel.org>,
        Matthias Schiffer <matthias.schiffer@...tq-group.com>,
        Sujit Kautkar <sujitka@...omium.org>,
        Zubin Mithra <zsm@...omium.org>
Subject: Re: [PATCH 0/2] Two mmc fixes for IDA and KASAN issues

On Wed, 23 Jun 2021 at 09:50, Stephen Boyd <swboyd@...omium.org> wrote:
>
> Here's a followup to a thread I sent a couple months ago[1]. They're only
> marginally related to each other, but I have bundled them here into one
> series to make it easier to track. Resending to restart the discussion.
>
> Cc: Matthias Schiffer <matthias.schiffer@...tq-group.com>
> Cc: Sujit Kautkar <sujitka@...omium.org>
> Cc: Zubin Mithra <zsm@...omium.org>
>
> [1] https://lore.kernel.org/r/20210413003621.1403300-1-swboyd@chromium.org
>
> Stephen Boyd (2):
>   mmc: block: Use kref in place of struct mmc_blk_data::usage
>   mmc: core: Don't allocate IDA for OF aliases
>
>  drivers/mmc/core/block.c | 35 +++++++++++++++++++++--------------
>  drivers/mmc/core/host.c  | 20 ++++++++++----------
>  2 files changed, 31 insertions(+), 24 deletions(-)
>

My apologies for the delay! The changes look very good to me, thanks
for helping out!

FYI, I did some more thorough analysis of how the block device
reference counting/locking should be managed, from a generic point of
view. Your change in patch1 fixes the immediate problem with the KASAN
splat I reported, but also moves the code in the right direction.

However, there are lots of additional improvements that deserve to be
made (another possible KASAN splat) for this related mmc code. I am
looking into this and will keep you posted. :-)

So, this series is applied for fixes and stable tags added for both
patches. Again, thanks for helping out!

Kind regards
Uffe