[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <a429671e-927e-e5c8-cc33-ab4310446792@linux-m68k.org>
Date: Thu, 8 Jul 2021 22:33:22 +1000
From: Greg Ungerer <gerg@...ux-m68k.org>
To: Randy Dunlap <rdunlap@...radead.org>, linux-kernel@...r.kernel.org
Cc: linux-m68k@...ts.linux-m68k.org, uclinux-dev@...inux.org
Subject: Re: [PATCH] m68k/nommu: prevent setting ROMKERNEL when ROM is not set
Hi Randy,
On 8/7/21 2:37 am, Randy Dunlap wrote:
> When CONFIG_ROMKERNEL is set but CONFIG_ROM is not set, the linker
> complains:
> m68k-linux-ld:./arch/m68k/kernel/vmlinux.lds:5: undefined symbol `CONFIG_ROMSTART' referenced in expression
>
> # CONFIG_ROM is not set
> # CONFIG_RAMKERNEL is not set
> CONFIG_ROMKERNEL=y
>
> Since ROMSTART depends on ROM, make ROMKERNEL also depend on ROM.
>
> Signed-off-by: Randy Dunlap <rdunlap@...radead.org>
> Cc: Greg Ungerer <gerg@...ux-m68k.org>
> Cc: linux-m68k@...ts.linux-m68k.org
> Cc: uclinux-dev@...inux.org
Looks good, thanks.
I will apply to for-next branch of m68knommu git tree when the current
merge window closes.
Regards
Greg
> ---
> arch/m68k/Kconfig.machine | 1 +
> 1 file changed, 1 insertion(+)
>
> --- linux-next-20210701.orig/arch/m68k/Kconfig.machine
> +++ linux-next-20210701/arch/m68k/Kconfig.machine
> @@ -464,6 +464,7 @@ config RAMKERNEL
>
> config ROMKERNEL
> bool "ROM"
> + depends on ROM
> help
> The kernel will be resident in FLASH/ROM when running. This is
> often referred to as Execute-in-Place (XIP), since the kernel
>
Powered by blists - more mailing lists