linux-kernel - Re: [PATCH v1 1/1] mmc: mmc_spi: Simplify busy loop in mmc_spi

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAHp75VfdDXwboZWZgRdFNXLpONy8UgDryeZWd6UD2RaCXo=uOw@mail.gmail.com>
Date:   Thu, 8 Jul 2021 15:49:32 +0300
From:   Andy Shevchenko <andy.shevchenko@...il.com>
To:     Ulf Hansson <ulf.hansson@...aro.org>
Cc:     Andy Shevchenko <andriy.shevchenko@...ux.intel.com>,
        linux-mmc <linux-mmc@...r.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v1 1/1] mmc: mmc_spi: Simplify busy loop in mmc_spi_skip()

On Thu, Jul 8, 2021 at 3:33 PM Ulf Hansson <ulf.hansson@...aro.org> wrote:
> On Wed, 23 Jun 2021 at 12:17, Andy Shevchenko
> <andriy.shevchenko@...ux.intel.com> wrote:

...

> This certainly is an improvement.
>
> Although, what do you think of moving to readx_poll_timeout(), that
> should allow even a better cleanup, don't you think?

I believe you meant rather read_poll_timeout(). Either way I don't see
the benefit of using that macro when you have to customize its body a
lot. Besides that the macro doesn't use cond_sched() or even
schedule() and I'm not sure it will be an equivalent change.

That said, I prefer going this patch as is for the time being. We may
adjust it later on.

-- 
With Best Regards,
Andy Shevchenko