linux-kernel - Re: [PATCH v6 3/5] media: i2c: add driver for the SK Hynix Hi-846 8M pixel camera

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20210708125729.GZ3@valkosipuli.retiisi.eu>
Date:   Thu, 8 Jul 2021 15:57:29 +0300
From:   Sakari Ailus <sakari.ailus@....fi>
To:     Martin Kepplinger <martin.kepplinger@...i.sm>
Cc:     krzysztof.kozlowski@...onical.com,
        laurent.pinchart@...asonboard.com, devicetree@...r.kernel.org,
        kernel@...i.sm, linux-kernel@...r.kernel.org,
        linux-media@...r.kernel.org, mchehab@...nel.org,
        paul.kocialkowski@...tlin.com, pavel@....cz,
        phone-devel@...r.kernel.org, robh@...nel.org, shawnx.tu@...el.com
Subject: Re: [PATCH v6 3/5] media: i2c: add driver for the SK Hynix Hi-846 8M
 pixel camera

Hi Martin,

On Mon, Jun 28, 2021 at 12:10:52PM +0200, Martin Kepplinger wrote:
...
> +	hi846->clock = devm_clk_get(&client->dev, NULL);
> +	if (IS_ERR(hi846->clock)) {
> +		dev_err(&client->dev, "failed to get clock: %pe\n", hi846->clock);
> +		return PTR_ERR(hi846->clock);
> +	}
> +
> +	mclk_freq = clk_get_rate(hi846->clock);
> +	dev_dbg(&client->dev, "clk rate: %u\n", mclk_freq);

You'll need to check this is the value you expect it to be. The register
lists are specific to that value.

Could you also check Documentation/driver-api/media/camera-sensor.rst
regarding the assigned-clocks etc. properties, and align the bindings with
that?

-- 
Sakari Ailus