linux-kernel - Re: [PATCH] bus: Make remove callback return void

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20210708021913.GB12358@yilunxu-OptiPlex-7050>
Date:   Thu, 8 Jul 2021 10:19:13 +0800
From:   Xu Yilun <yilun.xu@...el.com>
To:     Tom Rix <trix@...hat.com>
Cc:     Uwe Kleine-König 
        <u.kleine-koenig@...gutronix.de>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        linux-kernel@...r.kernel.org, Wu Hao <hao.wu@...el.com>,
        Moritz Fischer <mdf@...nel.org>, linux-fpga@...r.kernel.org
Subject: Re: [PATCH] bus: Make remove callback return void

On Tue, Jul 06, 2021 at 06:52:09AM -0700, Tom Rix wrote:
> 
> On 7/6/21 2:50 AM, Uwe Kleine-König wrote:
> > The driver core ignores the return value of this callback because there
> > is only little it can do when a device disappears.
> > 
> > This is the final bit of a long lasting cleanup quest where several
> > buses were converted to also return void from their remove callback.
> > Additionally some resource leaks were fixed that were caused by drivers
> > returning an error code in the expectation that the driver won't go
> > away.
> > 
> > With struct bus_type::remove returning void it's prevented that newly
> > implemented buses return an ignored error code and so don't anticipate
> > wrong expectations for driver authors.
> > 
> > Signed-off-by: Uwe Kleine-König <u.kleine-koenig@...gutronix.de>
> > ---
> > Hello,
> > 
> > this patch depends on "PCI: endpoint: Make struct pci_epf_driver::remove
> > return void" that is not yet applied, see
> > https://lore.kernel.org/r/20210223090757.57604-1-u.kleine-koenig@pengutronix.de.
> > 
> > I tested it using allmodconfig on amd64 and arm, but I wouldn't be
> > surprised if I still missed to convert a driver. So it would be great to
> > get this into next early after the merge window closes.
> > 
> > I send this mail to all people that get_maintainer.pl emits for this
> > patch. I wonder how many recipents will refuse this mail because of the
> > long Cc: list :-)
> > 
> > Best regards
> > Uwe
> 
> >   drivers/fpga/dfl.c                        | 4 +---
> Reviewed-by: Tom Rix <trix@...hat.com>
Reviewed-by: Xu Yilun <yilun.xu@...el.com>