linux-kernel - Re: [PATCH 04/12] ASoC: amd: create acp5x platform devices

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <2361319f-805d-e3e8-d86c-e0ecd39233ea@amd.com>
Date:   Thu, 8 Jul 2021 20:32:38 +0530
From:   "Mukunda,Vijendar" <vijendar.mukunda@....com>
To:     Mark Brown <broonie@...nel.org>
Cc:     alsa-devel@...a-project.org, Alexander.Deucher@....com,
        Sunil-kumar.Dommati@....com, Liam Girdwood <lgirdwood@...il.com>,
        Jaroslav Kysela <perex@...ex.cz>,
        Takashi Iwai <tiwai@...e.com>,
        open list <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 04/12] ASoC: amd: create acp5x platform devices

On 7/7/21 9:52 PM, Mark Brown wrote:
> On Wed, Jul 07, 2021 at 11:26:15AM +0530, Vijendar Mukunda wrote:
> 
>> +#define I2S_MODE 0x00
>> +#define ACP5x_I2S_MODE 0x00
> 
> All the other constants are namespaced so why the plain I2S_MODE?

Already we have defined ACP5x_I2S_MODE to check whether ACP Audio mode
is set to I2S or not.
I2S_MODE macro to match one of the value of ACP_PIN_CONFIG which will be
programmed from BIOS based on Audio Configuration.
When few other audio modes added, will move ACP_PIN_CONFIG macro
definitions to enum.

> 
>> +	val = acp_readl(adata->acp5x_base + ACP_PIN_CONFIG);
>> +	switch (val) {
>> +	case I2S_MODE:
> 
> ...
> 
>> +		break;
>> +	default:
>> +		dev_info(&pci->dev, "ACP audio mode : %d\n", val);
>> +	}
> 
> Given that anything other than I2S is basically unhandled should we
> perhaps print an error rather than just an info message
> 

As mentioned above, ACP IP also supports other audio configurations.
When other audio configuration is selected, ACP PCI driver should be
loaded. see - efb38304c(ASoC: amd: support other audio modes for raven)