linux-kernel - Re: [PATCH] drivers: Follow the indentation coding standard on printks

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 8 Jul 2021 16:53:48 +0200
From:   Andrew Lunn <andrew@...n.ch>
To:     Carlos Bilbao <bilbao@...edu>
Cc:     gregkh@...uxfoundation.org, alexander.deucher@....com,
        davem@...emloft.net, mchehab+huawei@...nel.org, kuba@...nel.org,
        James.Bottomley@...senpartnership.com, netdev@...r.kernel.org,
        linux-parisc@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] drivers: Follow the indentation coding standard on
 printks

> --- a/drivers/atm/suni.c
> +++ b/drivers/atm/suni.c
> @@ -328,8 +328,8 @@ static int suni_start(struct atm_dev *dev)
>  		timer_setup(&poll_timer, suni_hz, 0);
>  		poll_timer.expires = jiffies+HZ;
>  #if 0
> -printk(KERN_DEBUG "[u] p=0x%lx,n=0x%lx\n",(unsigned long) poll_timer.list.prev,
> -    (unsigned long) poll_timer.list.next);
> +	printk(KERN_DEBUG "[u] p=0x%lx,n=0x%lx\n",(unsigned long) poll_timer.list.prev,
> +	    (unsigned long) poll_timer.list.next);

Why not use DPRINTK(), defined at the start of suni.c?

    Andrew