linux-kernel - Re: [PATCH] KVM: VMX: Remove vmx_msr

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <52d7d0f8-231a-58f0-fafc-489e3b11742e@redhat.com>
Date:   Thu, 8 Jul 2021 19:04:09 +0200
From:   Paolo Bonzini <pbonzini@...hat.com>
To:     Yu Zhang <yu.c.zhang@...ux.intel.com>
Cc:     seanjc@...gle.com, vkuznets@...hat.com, wanpengli@...cent.com,
        jmattson@...gle.com, joro@...tes.org, tglx@...utronix.de,
        bp@...en8.de, x86@...nel.org, hpa@...or.com, kvm@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] KVM: VMX: Remove vmx_msr_index from vmx.h

On 08/07/21 01:57, Yu Zhang wrote:
> vmx_msr_index was used to record the list of MSRs which can be lazily
> restored when kvm returns to userspace. It is now reimplemented as
> kvm_uret_msrs_list, a common x86 list which is only used inside x86.c.
> So just remove the obsolete declaration in vmx.h.
> 
> Signed-off-by: Yu Zhang <yu.c.zhang@...ux.intel.com>
> ---
>   arch/x86/kvm/vmx/vmx.h | 2 --
>   1 file changed, 2 deletions(-)
> 
> diff --git a/arch/x86/kvm/vmx/vmx.h b/arch/x86/kvm/vmx/vmx.h
> index 3979a947933a..db88ed4f2121 100644
> --- a/arch/x86/kvm/vmx/vmx.h
> +++ b/arch/x86/kvm/vmx/vmx.h
> @@ -14,8 +14,6 @@
>   #include "vmx_ops.h"
>   #include "cpuid.h"
>   
> -extern const u32 vmx_msr_index[];
> -
>   #define MSR_TYPE_R	1
>   #define MSR_TYPE_W	2
>   #define MSR_TYPE_RW	3
> 

Queued, thanks.

Paolo