linux-kernel - Re: [PATCH net-next v2] drivers: atm: Follow the indentation coding standard on printks

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <YOdA0vy58Lr6FPeE@lunn.ch>
Date:   Thu, 8 Jul 2021 20:15:46 +0200
From:   Andrew Lunn <andrew@...n.ch>
To:     Carlos Bilbao <bilbao@...edu>
Cc:     3chas3@...il.com, linux-atm-general@...ts.sourceforge.net,
        gregkh@...uxfoundation.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH net-next v2] drivers: atm: Follow the indentation coding
 standard on printks

> diff --git a/drivers/atm/iphase.c b/drivers/atm/iphase.c
> index bc8e8d9f176b..8a3ee51e6c9f 100644
> --- a/drivers/atm/iphase.c
> +++ b/drivers/atm/iphase.c
> @@ -1246,8 +1246,8 @@ static void rx_intr(struct atm_dev *dev)
>                 ((iadev->rx_pkt_cnt - iadev->rx_tmp_cnt) == 0)) {
>          for (i = 1; i <= iadev->num_rx_desc; i++)
>                 free_desc(dev, i);
> -printk("Test logic RUN!!!!\n");
> -        writew( ~(RX_FREEQ_EMPT|RX_EXCP_RCVD),iadev->reass_reg+REASS_MASK_REG);
> +        printk("Test logic RUN!!!!\n");
> + 	writew( ~(RX_FREEQ_EMPT|RX_EXCP_RCVD),iadev->reass_reg+REASS_MASK_REG);
>          iadev->rxing = 1;
>       }

It looks like you turned a set of spaces into a tab for the writew()
line. Please don't make such whitespace changes in the same patch as
other changes.

Yes, lots of things to learn before you get your first patch accepted...

>> +++ b/drivers/atm/zatm.c
> @@ -664,7 +644,7 @@ static int do_tx(struct sk_buff *skb)
>  		EVENT("dsc (0x%lx)\n",(unsigned long) dsc,0);
>  	}
>  	else {
> -printk("NONONONOO!!!!\n");
> +		printk("NONONONOO!!!!\n");
>  		dsc = NULL;

This seems like an error message. So maybe

     pr_err("NONONONOO!!!!\n");

These ATM drivers don't appear to be netdev drivers. There does not
appear to be a struct device available, so you have to fall back to
pr_err(), pr_info() etc.

	  Andrew