linux-kernel - Re: [PATCH] tracing/selftests: Add tests to test histogram sym and sym-offset modifiers

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20210708130807.f502ab87cdc7bc90a47b211f@kernel.org>
Date:   Thu, 8 Jul 2021 13:08:07 +0900
From:   Masami Hiramatsu <mhiramat@...nel.org>
To:     Steven Rostedt <rostedt@...dmis.org>
Cc:     LKML <linux-kernel@...r.kernel.org>,
        Ingo Molnar <mingo@...nel.org>,
        Andrew Morton <akpm@...ux-foundation.org>,
        Tom Zanussi <zanussi@...nel.org>,
        Masami Hiramatsu <mhiramat@...nel.org>,
        Namhyung Kim <namhyung@...nel.org>,
        Daniel Bristot de Oliveira <bristot@...hat.com>,
        Shuah Khan <shuah@...nel.org>,
        Shuah Khan <skhan@...uxfoundation.org>
Subject: Re: [PATCH] tracing/selftests: Add tests to test histogram sym and
 sym-offset modifiers

On Wed, 7 Jul 2021 12:14:51 -0400
Steven Rostedt <rostedt@...dmis.org> wrote:

> From: "Steven Rostedt (VMware)" <rostedt@...dmis.org>
> 
> Add a test to the tracing selftests that will catch if the .sym or
> .sym-offset modifiers break in the future.
> 
> Signed-off-by: Steven Rostedt (VMware) <rostedt@...dmis.org>

Looks good to me.

Acked-by: Masami Hiramatsu <mhiramat@...nel.org>

Thank you!

> ---
>  .../ftrace/test.d/trigger/trigger-hist.tc      | 18 ++++++++++++++++++
>  1 file changed, 18 insertions(+)
> 
> diff --git a/tools/testing/selftests/ftrace/test.d/trigger/trigger-hist.tc b/tools/testing/selftests/ftrace/test.d/trigger/trigger-hist.tc
> index 2950bfbc6fce..adae72665500 100644
> --- a/tools/testing/selftests/ftrace/test.d/trigger/trigger-hist.tc
> +++ b/tools/testing/selftests/ftrace/test.d/trigger/trigger-hist.tc
> @@ -39,6 +39,24 @@ grep "parent_comm: $COMM" events/sched/sched_process_fork/hist > /dev/null || \
>  
>  reset_trigger
>  
> +echo "Test histogram with sym modifier"
> +
> +echo 'hist:keys=call_site.sym' > events/kmem/kmalloc/trigger
> +for i in `seq 1 10` ; do ( echo "forked" > /dev/null); done
> +grep '{ call_site: \[[0-9a-f][0-9a-f]*\] [_a-zA-Z][_a-zA-Z]* *}' events/kmem/kmalloc/hist > /dev/null || \
> +    fail "sym modifier on kmalloc call_site did not work"
> +
> +reset_trigger
> +
> +echo "Test histogram with sym-offset modifier"
> +
> +echo 'hist:keys=call_site.sym-offset' > events/kmem/kmalloc/trigger
> +for i in `seq 1 10` ; do ( echo "forked" > /dev/null); done
> +grep '{ call_site: \[[0-9a-f][0-9a-f]*\] [_a-zA-Z][_a-zA-Z]*+0x[0-9a-f][0-9a-f]*' events/kmem/kmalloc/hist > /dev/null || \
> +    fail "sym-offset modifier on kmalloc call_site did not work"
> +
> +reset_trigger
> +
>  echo "Test histogram with sort key"
>  
>  echo 'hist:keys=parent_pid,child_pid:sort=child_pid.ascending' > events/sched/sched_process_fork/trigger
> -- 
> 2.31.1
> 


-- 
Masami Hiramatsu <mhiramat@...nel.org>