linux-kernel - Re: [PATCH 2/2 v3] tracing/histogram: Update the documentation for the buckets modifier

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20210708161158.7eaa6b13@gandalf.local.home>
Date:   Thu, 8 Jul 2021 16:11:58 -0400
From:   Steven Rostedt <rostedt@...dmis.org>
To:     Tom Zanussi <zanussi@...nel.org>
Cc:     linux-kernel@...r.kernel.org, Ingo Molnar <mingo@...nel.org>,
        Andrew Morton <akpm@...ux-foundation.org>,
        Masami Hiramatsu <mhiramat@...nel.org>,
        Namhyung Kim <namhyung@...nel.org>,
        Daniel Bristot de Oliveira <bristot@...hat.com>
Subject: Re: [PATCH 2/2 v3] tracing/histogram: Update the documentation for
 the buckets modifier

On Thu, 08 Jul 2021 15:05:16 -0500
Tom Zanussi <zanussi@...nel.org> wrote:

> > -    # echo 'hist:key=call_site:val=bytes_req' > \
> > +    # echo 'hist:key=call_site:val=bytes_req.buckets=32' > \
> >              /sys/kernel/debug/tracing/events/kmem/kmalloc/trigger  
> 
> This just seems random, not sure why you changed it, and it doesn't
> make sense on a val anyway..

Good catch! I originally wrote this to explain the buckets in this
location, and then realized it did not match the flow, and moved my text
down. It appears that I missed putting back the original trigger. Will fix
and send a v4.

> 
> The rest looks good, though, thanks for doing this!
> 
> Reviewed-by: Tom Zanussi <zanussi@...nel.org>

Thanks!

-- Steve