linux-kernel - Re: linux-next: Fixes tag needs some work in the net tree

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <aa475f3f-339a-59b1-d92d-aa0748838c45@gmail.com>
Date:   Thu, 8 Jul 2021 14:45:45 -0700
From:   Florian Fainelli <f.fainelli@...il.com>
To:     Eric Dumazet <eric.dumazet@...il.com>,
        Stephen Rothwell <sfr@...b.auug.org.au>,
        David Miller <davem@...emloft.net>,
        Networking <netdev@...r.kernel.org>
Cc:     Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        Linux Next Mailing List <linux-next@...r.kernel.org>
Subject: Re: linux-next: Fixes tag needs some work in the net tree

On 7/8/21 2:44 PM, Eric Dumazet wrote:
> 
> 
> On 7/8/21 11:38 PM, Florian Fainelli wrote:
>> On 7/8/21 2:31 PM, Stephen Rothwell wrote:
>>> Hi all,
>>>
>>> In commit
>>>
>>>   9615fe36b31d ("skbuff: Fix build with SKB extensions disabled")
>>>
>>> Fixes tag
>>>
>>>   Fixes: Fixes: 8550ff8d8c75 ("skbuff: Release nfct refcount on napi stolen or re-used skbs")
>>>
>>> has these problem(s):
>>>
>>>   - No SHA1 recognised
>>>
>>> Not worth rebasing for, just more care next time.
>>
>> It is there though:
>>
>> https://git.kernel.org/pub/scm/linux/kernel/git/netdev/net.git/commit/?id=8550ff8d8c75416e984d9c4b082845e57e560984
>>
>> and has the proper format AFAICT, what am I missing?
>>
> 
> This commit was the first commit, adding the bug.
> 
> Your commit changelog had :
> 
>     Fixes: Fixes: 8550ff8d8c75 ("skbuff: Release nfct refcount on napi stolen or re-used skbs")
>     Signed-off-by: Florian Fainelli <f.fainelli@...il.com>
>     Reviewed-by: Roi Dayan <roid@...dia.com>
>     Reviewed-by: Eric Dumazet <edumazet@...gle.com>
>     Signed-off-by: David S. Miller <davem@...emloft.net>
> 
> See the extra Fixes: word ?

Doh! yes, sorry about that.
-- 
Florian