linux-kernel - RE: [PATCH v1 0/4] AD7949 Fixes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Fri, 9 Jul 2021 08:12:28 +0000
From:   "Sa, Nuno" <Nuno.Sa@...log.com>
To:     Liam Beguin <liambeguin@...il.com>,
        "lars@...afoo.de" <lars@...afoo.de>,
        "Hennerich, Michael" <Michael.Hennerich@...log.com>,
        "jic23@...nel.org" <jic23@...nel.org>,
        "charles-antoine.couret@...ensium.com" 
        <charles-antoine.couret@...ensium.com>
CC:     "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "linux-iio@...r.kernel.org" <linux-iio@...r.kernel.org>,
        "devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
        "robh+dt@...nel.org" <robh+dt@...nel.org>
Subject: RE: [PATCH v1 0/4] AD7949 Fixes

Hi Liam,

The series looks good. Just some minor comments from my side...

Thanks!
- Nuno Sá

> From: Liam Beguin <liambeguin@...il.com>
> Sent: Friday, July 9, 2021 1:56 AM
> To: liambeguin@...il.com; lars@...afoo.de; Hennerich, Michael
> <Michael.Hennerich@...log.com>; jic23@...nel.org; charles-
> antoine.couret@...ensium.com
> Cc: linux-kernel@...r.kernel.org; linux-iio@...r.kernel.org;
> devicetree@...r.kernel.org; robh+dt@...nel.org
> Subject: [PATCH v1 0/4] AD7949 Fixes
> 
> [External]
> 
> While working on another series[1] I ran into issues where my SPI
> controller would fail to handle 14-bit and 16-bit SPI messages. This
> addresses that issue and adds support for selecting a different voltage
> reference source from the devicetree.
> 
> This is base on a series[2] that seems to not have made it all the way,
> and was tested on an ad7689.
> 
> [1]
> https://urldefense.com/v3/__https://patchwork.kernel.org/project/li
> nux-iio/list/?series=511545__;!!A3Ni8CS0y2Y!rF7O-WxC7HZM4hv_o-
> zYPtVCmZlDoASzPvamwwQkH9llVS8J-GpfQltvDBz7gQ$
> [2]
> https://urldefense.com/v3/__https://patchwork.kernel.org/project/li
> nux-
> iio/list/?series=116971&state=*2A&archive=both__;JQ!!A3Ni8CS0y2Y!
> rF7O-WxC7HZM4hv_o-zYPtVCmZlDoASzPvamwwQkH9llVS8J-GpfQluZ-
> w3LYA$
> 
> Thanks for your time,
> Liam
> 
> Liam Beguin (4):
>   iio: adc: ad7949: define and use bitfield names
>   iio: adc: ad7949: fix spi messages on non 14-bit controllers
>   iio: adc: ad7949: add support for internal vref
>   dt-bindings: iio: adc: ad7949: add adi,reference-source
> 
>  .../bindings/iio/adc/adi,ad7949.yaml          |  22 ++
>  drivers/iio/adc/ad7949.c                      | 191 +++++++++++++++---
>  2 files changed, 181 insertions(+), 32 deletions(-)
> 
> 
> base-commit: 6cbb3aa0f9d5d23221df787cf36f74d3866fdb78
> --
> 2.30.1.489.g328c10930387