linux-kernel - Re: [PATCH 1/2] mfd: atmel-flexcom: remove #ifdef CONFIG_PM

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Fri, 9 Jul 2021 11:11:40 +0200
From:   Nicolas Ferre <nicolas.ferre@...rochip.com>
To:     Claudiu Beznea <claudiu.beznea@...rochip.com>,
        <lee.jones@...aro.org>, <alexandre.belloni@...tlin.com>,
        <ludovic.desroches@...rochip.com>, <romain.izard.pro@...il.com>
CC:     <linux-arm-kernel@...ts.infradead.org>,
        <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 1/2] mfd: atmel-flexcom: remove #ifdef CONFIG_PM_SLEEP

On 05/07/2021 at 13:31, Claudiu Beznea wrote:
> Remove compilation flag and use __maybe_unused and pm_ptr instead.
> 
> Signed-off-by: Claudiu Beznea <claudiu.beznea@...rochip.com>

Acked-by: Nicolas Ferre <nicolas.ferre@...rochip.com>

> ---
>   drivers/mfd/atmel-flexcom.c | 6 ++----
>   1 file changed, 2 insertions(+), 4 deletions(-)
> 
> diff --git a/drivers/mfd/atmel-flexcom.c b/drivers/mfd/atmel-flexcom.c
> index d2f5c073fdf3..962f66dc8813 100644
> --- a/drivers/mfd/atmel-flexcom.c
> +++ b/drivers/mfd/atmel-flexcom.c
> @@ -87,8 +87,7 @@ static const struct of_device_id atmel_flexcom_of_match[] = {
>   };
>   MODULE_DEVICE_TABLE(of, atmel_flexcom_of_match);
>   
> -#ifdef CONFIG_PM_SLEEP
> -static int atmel_flexcom_resume(struct device *dev)
> +static int __maybe_unused atmel_flexcom_resume(struct device *dev)
>   {
>   	struct atmel_flexcom *ddata = dev_get_drvdata(dev);
>   	int err;
> @@ -105,7 +104,6 @@ static int atmel_flexcom_resume(struct device *dev)
>   
>   	return 0;
>   }
> -#endif
>   
>   static SIMPLE_DEV_PM_OPS(atmel_flexcom_pm_ops, NULL,
>   			 atmel_flexcom_resume);
> @@ -114,7 +112,7 @@ static struct platform_driver atmel_flexcom_driver = {
>   	.probe	= atmel_flexcom_probe,
>   	.driver	= {
>   		.name		= "atmel_flexcom",
> -		.pm		= &atmel_flexcom_pm_ops,
> +		.pm		= pm_ptr(&atmel_flexcom_pm_ops),
>   		.of_match_table	= atmel_flexcom_of_match,
>   	},
>   };
> 


-- 
Nicolas Ferre