lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite for Android: free password hash cracker in your pocket
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20210709093852.GY3840@techsingularity.net>
Date:   Fri, 9 Jul 2021 10:38:52 +0100
From:   Mel Gorman <mgorman@...hsingularity.net>
To:     Yang Huan <link@...o.com>
Cc:     Andrew Morton <akpm@...ux-foundation.org>, linux-mm@...ck.org,
        linux-kernel@...r.kernel.org, kernel@...o.com,
        Uladzislau Rezki <urezki@...il.com>
Subject: Re: [PATCH] mm/vmalloc: try alloc_pages_bulk first to get order 0
 pages fast

On Fri, Jul 09, 2021 at 05:28:31PM +0800, Yang Huan wrote:
> Vmalloc may offen get pages by loop invoke alloc_pags, this is
> cost too much time in count watermark/cpuset or something.
> Let's just try alloc by alloc_pages_bulk, if failed, fullback in
> original path.
> 
> With my own test, simulate loop alloc_page and alloc_pages_bulk_array,
> get this:
> size		1M	10M	20M	30
> normal		44	1278	3665	5581
> test		34	889	2167	3300
> optimize	22%	30%	40%	40%
> And in my vmalloc top sort, zram/f2fs may alloc more than 20MB, so,
> It's worth to use alloc_pages_bulk.
> 
> Signed-off-by: Yang Huan <link@...o.com>

Thanks. I suggest you take a look at the current merge window and check
if anything additional needs to be done after the vmalloc bulk allocation
by Uladzislau Rezki.

-- 
Mel Gorman
SUSE Labs

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ