linux-kernel - Re: [PATCH] drivers: Follow the indentation coding standard on printks

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <2693E7F6-4D6D-4EF4-B2B4-102C044AB2AC@vt.edu>
Date:   Fri, 9 Jul 2021 06:30:40 -0400
From:   bilbao@...edu
To:     Helge Deller <deller@....de>
Cc:     Rolf Eike Beer <eike-kernel@...tec.de>, gregkh@...uxfoundation.org,
        davem@...emloft.net, kuba@...nel.org,
        James.Bottomley@...senpartnership.com, netdev@...r.kernel.org,
        linux-parisc@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] drivers: Follow the indentation coding standard on printks

Helge,

I would like to finish what I started and take care of this, yes.

thanks,
Carlos.

> On Jul 9, 2021, at 2:43 AM, Helge Deller <deller@....de> wrote:
> 
> On 7/8/21 11:25 PM, Rolf Eike Beer wrote:
>> Am Donnerstag, 8. Juli 2021, 15:10:01 CEST schrieb Carlos Bilbao:
>>> Fix indentation of printks that start at the beginning of the line. Change
>>> this for the right number of space characters, or tabs if the file uses
>>> them.
>> [...]
>>> --- a/drivers/parisc/iosapic.c
>>> +++ b/drivers/parisc/iosapic.c
>>> @@ -633,7 +633,7 @@ static void iosapic_unmask_irq(struct irq_data *d)
>>>     printk("\n");
>>> }
>>> -printk("iosapic_enable_irq(): sel ");
>>> +    printk("iosapic_enable_irq(): sel ");
>>> {
>>>     struct iosapic_info *isp = vi->iosapic;
>>> @@ -642,7 +642,7 @@ printk("iosapic_enable_irq(): sel ");
>>>         printk(" %x", d1);
>>>     }
>>> }
>>> -printk("\n");
>>> +    printk("\n");
>>> #endif
>>>     /*
>> This is also debug code. It is basically unchanged since it has been imported
>> into git. So it may be time to remove the whole block. Helge?
> 
> I'd prefer to clean it proper up and keep it.
> 
> 
>>> diff --git a/drivers/parisc/sba_iommu.c b/drivers/parisc/sba_iommu.c
>>> index dce4cdf786cd..c3381facdfc5 100644
>>> --- a/drivers/parisc/sba_iommu.c
>>> +++ b/drivers/parisc/sba_iommu.c
>>> @@ -1550,7 +1550,7 @@ static void sba_hw_init(struct sba_device *sba_dev)
>>> #if 0
>>> -printk("sba_hw_init(): mem_boot 0x%x 0x%x 0x%x 0x%x\n",
>>> PAGE0->mem_boot.hpa,
>>> +    printk("sba_hw_init(): mem_boot 0x%x 0x%x 0x%x
>>> 0x%x\n", PAGE0->mem_boot.hpa, PAGE0->mem_boot.spa, PAGE0->mem_boot.pad,
>>> PAGE0->mem_boot.cl_class);
>>>     /*
>> This is equally old. It should be either also removed, also this seems at
>> least worth as documentation. Maybe just switch it to pr_debug() or
>> dev_debug() while fixing the indentation.
> 
> Yes, I'll clean it up too.
> 
> @Carlos:
> Instead of just removing or fixing the indentation, I'll fix it for both parisc
> drivers. Unless you want to try...
> 
> Helge