linux-kernel - Re: [PATCH 4.4.y] arm: kprobes: Allow to handle reentered kprobe on single-stepping

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Fri, 9 Jul 2021 15:06:56 +0200
From:   Greg KH <gregkh@...uxfoundation.org>
To:     Shaobo Huang <huangshaobo6@...wei.com>
Cc:     chenzefeng2@...wei.com, kepler.chenxin@...wei.com,
        linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org,
        linux@....linux.org.uk, liucheng32@...wei.com, mhiramat@...nel.org,
        nixiaoming@...wei.com, tixy@...aro.org, xiaoqian9@...wei.com,
        young.liuyang@...wei.com, zengweilin@...wei.com
Subject: Re: [PATCH 4.4.y] arm: kprobes: Allow to handle reentered kprobe on
 single-stepping

On Fri, Jul 09, 2021 at 10:46:30AM +0800, Shaobo Huang wrote:
> From: Masami Hiramatsu <mhiramat@...nel.org>
> 
> commit f3fbd7ec62dec1528fb8044034e2885f2b257941 upstream
> 
> This is arm port of commit 6a5022a56ac3 ("kprobes/x86: Allow to
> handle reentered kprobe on single-stepping")
> 
> Since the FIQ handlers can interrupt in the single stepping
> (or preparing the single stepping, do_debug etc.), we should
> consider a kprobe is hit in the NMI handler. Even in that
> case, the kprobe is allowed to be reentered as same as the
> kprobes hit in kprobe handlers
> (KPROBE_HIT_ACTIVE or KPROBE_HIT_SSDONE).
> 
> The real issue will happen when a kprobe hit while another
> reentered kprobe is processing (KPROBE_REENTER), because
> we already consumed a saved-area for the previous kprobe.
> 
> Signed-off-by: Masami Hiramatsu <mhiramat@...nel.org>
> Signed-off-by: Jon Medhurst <tixy@...aro.org>
> Fixes: 24ba613c9d6c ("ARM kprobes: core code")
> Cc: stable@...r.kernel.org #v2.6.25~v4.11
> Signed-off-by: huangshaobo <huangshaobo6@...wei.com>
> ---
>  arch/arm/probes/kprobes/core.c | 6 ++++++
>  1 file changed, 6 insertions(+)

Now queued up, thanks.

greg k-h