linux-kernel - Re: [PATCH] drivers: parisc: Update iosapic driver with proper printks

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <7261873.EvYhyI6sBW@daneel.sf-tec.de>
Date:   Fri, 09 Jul 2021 18:05:05 +0200
From:   Rolf Eike Beer <eike-kernel@...tec.de>
To:     James.Bottomley@...senpartnership.com,
        Carlos Bilbao <bilbao@...edu>
Cc:     deller@....de, linux-parisc@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] drivers: parisc: Update iosapic driver with proper printks

Am Freitag, 9. Juli 2021, 15:38:44 CEST schrieb Carlos Bilbao:
> The code from the old I/O Sapic Driver is outdated when it comes to printks.
> Fix applying proper indentation and using dev_dbg() instead of printk on
> debugging blocks. Also add a KERN_<LEVEL> where it is missing.

Have you actually tried building this? I bet not:

> +#define DBG(x...) dev_dbg(x)

> +	DBG("io_sapic_info at %p\n", isi);
> +	DBG("\t\tisi_hpa:       %lx\n", isi->isi_hpa);
> +	DBG("\t\tisi_status:    %x\n", isi->isi_status);
> +	DBG("\t\tisi_version:   %x\n", isi->isi_version);
> +	DBG("\t\tisi_vector:    %p\n", isi->isi_vector);
>  }
>  #endif /* DEBUG_IOSAPIC */

You are not passing a struct device here, so this will not work.

Eike
Download attachment "signature.asc" of type "application/pgp-signature" (196 bytes)