| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <202107101006.9RXJFWV2-lkp@intel.com>
Date: Sat, 10 Jul 2021 10:21:08 +0800
From: kernel test robot <lkp@...el.com>
To: Bart Van Assche <bvanassche@....org>
Cc: kbuild-all@...ts.01.org, linux-kernel@...r.kernel.org
Subject: [bvanassche:scsi-remove-request-pointer 51/51]
drivers/scsi/mpi3mr/mpi3mr_os.c:53:37: error: 'struct scsi_cmnd' has no
member named 'request'
tree: https://github.com/bvanassche/linux scsi-remove-request-pointer
head: 2fab108311c3945a49c45df8859e5c517923577d
commit: 2fab108311c3945a49c45df8859e5c517923577d [51/51] core: Remove the request member from struct scsi_cmnd
config: arc-allyesconfig (attached as .config)
compiler: arceb-elf-gcc (GCC) 9.3.0
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# https://github.com/bvanassche/linux/commit/2fab108311c3945a49c45df8859e5c517923577d
git remote add bvanassche https://github.com/bvanassche/linux
git fetch --no-tags bvanassche scsi-remove-request-pointer
git checkout 2fab108311c3945a49c45df8859e5c517923577d
# save the attached .config to linux build tree
mkdir build_dir
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross O=build_dir ARCH=arc SHELL=/bin/bash drivers/infiniband/ulp/ drivers/scsi/mpi3mr/
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@...el.com>
All errors (new ones prefixed by >>):
drivers/scsi/mpi3mr/mpi3mr_os.c: In function 'mpi3mr_host_tag_for_scmd':
>> drivers/scsi/mpi3mr/mpi3mr_os.c:53:37: error: 'struct scsi_cmnd' has no member named 'request'
53 | unique_tag = blk_mq_unique_tag(scmd->request);
| ^~
In file included from include/linux/byteorder/big_endian.h:5,
from arch/arc/include/uapi/asm/byteorder.h:14,
from include/asm-generic/bitops/le.h:7,
from arch/arc/include/asm/bitops.h:373,
from include/linux/bitops.h:32,
from include/linux/kernel.h:12,
from include/linux/list.h:9,
from include/linux/rculist.h:10,
from include/linux/pid.h:5,
from include/linux/sched.h:14,
from include/linux/blkdev.h:5,
from drivers/scsi/mpi3mr/mpi3mr.h:13,
from drivers/scsi/mpi3mr/mpi3mr_os.c:10:
drivers/scsi/mpi3mr/mpi3mr_os.c: In function 'mpi3mr_setup_eedp':
drivers/scsi/mpi3mr/mpi3mr_os.c:2019:38: error: 'struct scsi_cmnd' has no member named 'request'
2019 | cpu_to_be32(t10_pi_ref_tag(scmd->request));
| ^~
include/uapi/linux/byteorder/big_endian.h:39:51: note: in definition of macro '__cpu_to_be32'
39 | #define __cpu_to_be32(x) ((__force __be32)(__u32)(x))
| ^
drivers/scsi/mpi3mr/mpi3mr_os.c:2019:7: note: in expansion of macro 'cpu_to_be32'
2019 | cpu_to_be32(t10_pi_ref_tag(scmd->request));
| ^~~~~~~~~~~
drivers/scsi/mpi3mr/mpi3mr_os.c:2027:38: error: 'struct scsi_cmnd' has no member named 'request'
2027 | cpu_to_be32(t10_pi_ref_tag(scmd->request));
| ^~
include/uapi/linux/byteorder/big_endian.h:39:51: note: in definition of macro '__cpu_to_be32'
39 | #define __cpu_to_be32(x) ((__force __be32)(__u32)(x))
| ^
drivers/scsi/mpi3mr/mpi3mr_os.c:2027:7: note: in expansion of macro 'cpu_to_be32'
2027 | cpu_to_be32(t10_pi_ref_tag(scmd->request));
| ^~~~~~~~~~~
drivers/scsi/mpi3mr/mpi3mr_os.c: In function 'mpi3mr_qcmd':
drivers/scsi/mpi3mr/mpi3mr_os.c:3454:27: error: 'struct scsi_cmnd' has no member named 'request'
3454 | struct request *rq = scmd->request;
| ^~
vim +53 drivers/scsi/mpi3mr/mpi3mr_os.c
74e1f30a286809 Kashyap Desai 2021-05-20 27
6fe3a4ab4c3138 Yang Yingliang 2021-06-04 28 static int prot_guard_mask = 3;
74e1f30a286809 Kashyap Desai 2021-05-20 29 module_param(prot_guard_mask, int, 0);
74e1f30a286809 Kashyap Desai 2021-05-20 30 MODULE_PARM_DESC(prot_guard_mask, " Host protection guard mask, def=3");
6fe3a4ab4c3138 Yang Yingliang 2021-06-04 31 static int logging_level;
824a156633dfdb Kashyap Desai 2021-05-20 32 module_param(logging_level, int, 0);
824a156633dfdb Kashyap Desai 2021-05-20 33 MODULE_PARM_DESC(logging_level,
824a156633dfdb Kashyap Desai 2021-05-20 34 " bits for enabling additional logging info (default=0)");
824a156633dfdb Kashyap Desai 2021-05-20 35
023ab2a9b4edd4 Kashyap Desai 2021-05-20 36 /* Forward declarations*/
023ab2a9b4edd4 Kashyap Desai 2021-05-20 37 /**
023ab2a9b4edd4 Kashyap Desai 2021-05-20 38 * mpi3mr_host_tag_for_scmd - Get host tag for a scmd
023ab2a9b4edd4 Kashyap Desai 2021-05-20 39 * @mrioc: Adapter instance reference
023ab2a9b4edd4 Kashyap Desai 2021-05-20 40 * @scmd: SCSI command reference
023ab2a9b4edd4 Kashyap Desai 2021-05-20 41 *
023ab2a9b4edd4 Kashyap Desai 2021-05-20 42 * Calculate the host tag based on block tag for a given scmd.
023ab2a9b4edd4 Kashyap Desai 2021-05-20 43 *
023ab2a9b4edd4 Kashyap Desai 2021-05-20 44 * Return: Valid host tag or MPI3MR_HOSTTAG_INVALID.
023ab2a9b4edd4 Kashyap Desai 2021-05-20 45 */
023ab2a9b4edd4 Kashyap Desai 2021-05-20 46 static u16 mpi3mr_host_tag_for_scmd(struct mpi3mr_ioc *mrioc,
023ab2a9b4edd4 Kashyap Desai 2021-05-20 47 struct scsi_cmnd *scmd)
023ab2a9b4edd4 Kashyap Desai 2021-05-20 48 {
023ab2a9b4edd4 Kashyap Desai 2021-05-20 49 struct scmd_priv *priv = NULL;
023ab2a9b4edd4 Kashyap Desai 2021-05-20 50 u32 unique_tag;
023ab2a9b4edd4 Kashyap Desai 2021-05-20 51 u16 host_tag, hw_queue;
023ab2a9b4edd4 Kashyap Desai 2021-05-20 52
023ab2a9b4edd4 Kashyap Desai 2021-05-20 @53 unique_tag = blk_mq_unique_tag(scmd->request);
023ab2a9b4edd4 Kashyap Desai 2021-05-20 54
023ab2a9b4edd4 Kashyap Desai 2021-05-20 55 hw_queue = blk_mq_unique_tag_to_hwq(unique_tag);
023ab2a9b4edd4 Kashyap Desai 2021-05-20 56 if (hw_queue >= mrioc->num_op_reply_q)
023ab2a9b4edd4 Kashyap Desai 2021-05-20 57 return MPI3MR_HOSTTAG_INVALID;
023ab2a9b4edd4 Kashyap Desai 2021-05-20 58 host_tag = blk_mq_unique_tag_to_tag(unique_tag);
023ab2a9b4edd4 Kashyap Desai 2021-05-20 59
023ab2a9b4edd4 Kashyap Desai 2021-05-20 60 if (WARN_ON(host_tag >= mrioc->max_host_ios))
023ab2a9b4edd4 Kashyap Desai 2021-05-20 61 return MPI3MR_HOSTTAG_INVALID;
023ab2a9b4edd4 Kashyap Desai 2021-05-20 62
023ab2a9b4edd4 Kashyap Desai 2021-05-20 63 priv = scsi_cmd_priv(scmd);
023ab2a9b4edd4 Kashyap Desai 2021-05-20 64 /*host_tag 0 is invalid hence incrementing by 1*/
023ab2a9b4edd4 Kashyap Desai 2021-05-20 65 priv->host_tag = host_tag + 1;
023ab2a9b4edd4 Kashyap Desai 2021-05-20 66 priv->scmd = scmd;
023ab2a9b4edd4 Kashyap Desai 2021-05-20 67 priv->in_lld_scope = 1;
023ab2a9b4edd4 Kashyap Desai 2021-05-20 68 priv->req_q_idx = hw_queue;
74e1f30a286809 Kashyap Desai 2021-05-20 69 priv->meta_chain_idx = -1;
023ab2a9b4edd4 Kashyap Desai 2021-05-20 70 priv->chain_idx = -1;
74e1f30a286809 Kashyap Desai 2021-05-20 71 priv->meta_sg_valid = 0;
023ab2a9b4edd4 Kashyap Desai 2021-05-20 72 return priv->host_tag;
023ab2a9b4edd4 Kashyap Desai 2021-05-20 73 }
023ab2a9b4edd4 Kashyap Desai 2021-05-20 74
:::::: The code at line 53 was first introduced by commit
:::::: 023ab2a9b4edd4b1b109d1982cd80e10c327fbb2 scsi: mpi3mr: Add support for queue command processing
:::::: TO: Kashyap Desai <kashyap.desai@...adcom.com>
:::::: CC: Martin K. Petersen <martin.petersen@...cle.com>
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
Download attachment ".config.gz" of type "application/gzip" (68140 bytes)
Powered by blists - more mailing lists