linux-kernel - Re: [PATCH] ARM: dts: sun8i: h3: orangepi-plus: Fix ethernet phy-mode

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20210710160213.nursu2vc3ef53nbo@gilmour>
Date:   Sat, 10 Jul 2021 18:02:13 +0200
From:   Maxime Ripard <maxime@...no.tech>
To:     Salvatore Bonaccorso <carnil@...ian.org>
Cc:     Jernej Škrabec <jernej.skrabec@...l.net>,
        Rob Herring <robh+dt@...nel.org>,
        Chen-Yu Tsai <wens@...nel.org>,
        Vagrant Cascadian <vagrant@...roducible-builds.org>,
        "B.R. Oake" <broake@...lfence.com>, devicetree@...r.kernel.org,
        linux-kernel@...r.kernel.org, linux-sunxi@...glegroups.com,
        linux-arm-kernel@...ts.infradead.org
Subject: Re: [PATCH] ARM: dts: sun8i: h3: orangepi-plus: Fix ethernet phy-mode

Hi Salvatore,

On Sat, Jul 10, 2021 at 03:09:55PM +0200, Salvatore Bonaccorso wrote:
> Hi Maxime,
> 
> On Mon, May 24, 2021 at 02:35:06PM +0200, Maxime Ripard wrote:
> > On Mon, May 24, 2021 at 02:21:11PM +0200, Salvatore Bonaccorso wrote:
> > > Commit bbc4d71d6354 ("net: phy: realtek: fix rtl8211e rx/tx delay
> > > config") sets the RX/TX delay according to the phy-mode property in the
> > > device tree. For the Orange Pi Plus board this is "rgmii", which is the
> > > wrong setting.
> > > 
> > > Following the example of a900cac3750b ("ARM: dts: sun7i: a20: bananapro:
> > > Fix ethernet phy-mode") the phy-mode is changed to "rgmii-id" which gets
> > > the Ethernet working again on this board.
> > > 
> > > Fixes: bbc4d71d6354 ("net: phy: realtek: fix rtl8211e rx/tx delay config")
> > > Reported-by: "B.R. Oake" <broake@...lfence.com>
> > > Reported-by: Vagrant Cascadian <vagrant@...roducible-builds.org>
> > > Link: https://bugs.debian.org/988574
> > > Signed-off-by: Salvatore Bonaccorso <carnil@...ian.org>
> > 
> > Applied, thanks!
> 
> Did this fall trough the cracks? 
> 
> I see it in
> https://git.kernel.org/pub/scm/linux/kernel/git/sunxi/linux.git/commit/?id=b19d3479f25e8a0ff24df0b46c82e50ef0f900dd
> but got not merged yet in mainline.

I'm not really sure what happened, but I did send it as part of a fix PR
here:

https://lore.kernel.org/linux-arm-kernel/ad7ba352-315c-4201-b922-4bf914a00d98.lettre@localhost/

But it was sent as part of one of the arm-soc PR for 5.14:

https://lore.kernel.org/linux-arm-kernel/20210709234054.10288-1-olof@lixom.net/

I'm not sure if it didn't get applied to the right branch, but it
doesn't seem to be part of the proper PR either.

Anyway, this is on its way to Linus, will be part of 5.14 and picked up
by the stable tree at some point in a 5.13.* kernel

Maxime