linux-kernel - Re: [PATCH] tools: PCI: Zero-initialize param

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <d4c250af-aa50-0ec0-c66a-104092646e15@gmail.com>
Date:   Sun, 11 Jul 2021 09:48:17 +0800
From:   Shunyong Yang <yang.shunyong@...il.com>
To:     bhelgaas@...gle.com, kishon@...com, lorenzo.pieralisi@....com,
        kw@...ux.com
Cc:     linux-pci@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] tools: PCI: Zero-initialize param

Hi, Bjorn and Kishon,

   Gentle ping. Would you please help to review and merge this tiny change?

Thansk.

Shunyong.

On 2021/6/27 8:39, Shunyong Yang wrote:
> The values in param may be random if they are not initialized, which
> may cause use_dma flag set even when "-d" option is not provided
> in command line. Initializing all members to 0 to solve this.
>
> Signed-off-by: Shunyong Yang <yang.shunyong@...il.com>
> ---
>   tools/pci/pcitest.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tools/pci/pcitest.c b/tools/pci/pcitest.c
> index 0a1344c45213..59bcd6220a58 100644
> --- a/tools/pci/pcitest.c
> +++ b/tools/pci/pcitest.c
> @@ -40,7 +40,7 @@ struct pci_test {
>   
>   static int run_test(struct pci_test *test)
>   {
> -	struct pci_endpoint_test_xfer_param param;
> +	struct pci_endpoint_test_xfer_param param = {0};
>   	int ret = -EINVAL;
>   	int fd;
>