linux-kernel - Re: [RFC PATCH v2 net-next 1/8] net: dsa: ocelot: remove unnecessary pci

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20210711163638.GB2219684@euler>
Date:   Sun, 11 Jul 2021 09:36:38 -0700
From:   Colin Foster <colin.foster@...advantage.com>
To:     Vladimir Oltean <olteanv@...il.com>
Cc:     andrew@...n.ch, vivien.didelot@...il.com, f.fainelli@...il.com,
        davem@...emloft.net, kuba@...nel.org, robh+dt@...nel.org,
        claudiu.manoil@....com, alexandre.belloni@...tlin.com,
        UNGLinuxDriver@...rochip.com, linux@...linux.org.uk,
        netdev@...r.kernel.org, devicetree@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [RFC PATCH v2 net-next 1/8] net: dsa: ocelot: remove unnecessary
 pci_bar variables

On Sat, Jul 10, 2021 at 10:53:18PM +0300, Vladimir Oltean wrote:
> On Sat, Jul 10, 2021 at 12:25:55PM -0700, Colin Foster wrote:
> > The pci_bar variables for the switch and imdio don't make sense for the
> > generic felix driver. Moving them to felix_vsc9959 to limit scope and
> > simplify the felix_info struct.
> > 
> > Signed-off-by: Colin Foster <colin.foster@...advantage.com>
> > ---
> 
> Reviewed-by: Vladimir Oltean <vladimir.oltean@....com>
> 
> Just one comment below.
> 
> >  drivers/net/dsa/ocelot/felix.h         |  2 --
> >  drivers/net/dsa/ocelot/felix_vsc9959.c | 11 +++++------
> >  2 files changed, 5 insertions(+), 8 deletions(-)
> > 
> > diff --git a/drivers/net/dsa/ocelot/felix.h b/drivers/net/dsa/ocelot/felix.h
> > index 4d96cad815d5..47769dd386db 100644
> > --- a/drivers/net/dsa/ocelot/felix.h
> > +++ b/drivers/net/dsa/ocelot/felix.h
> > @@ -20,8 +20,6 @@ struct felix_info {
> >  	int				num_ports;
> >  	int				num_tx_queues;
> >  	struct vcap_props		*vcap;
> > -	int				switch_pci_bar;
> > -	int				imdio_pci_bar;
> >  	const struct ptp_clock_info	*ptp_caps;
> >  
> >  	/* Some Ocelot switches are integrated into the SoC without the
> > diff --git a/drivers/net/dsa/ocelot/felix_vsc9959.c b/drivers/net/dsa/ocelot/felix_vsc9959.c
> > index f966a253d1c7..182ca749c8e2 100644
> > --- a/drivers/net/dsa/ocelot/felix_vsc9959.c
> > +++ b/drivers/net/dsa/ocelot/felix_vsc9959.c
> > @@ -1359,8 +1359,6 @@ static const struct felix_info felix_info_vsc9959 = {
> >  	.num_mact_rows		= 2048,
> >  	.num_ports		= 6,
> >  	.num_tx_queues		= OCELOT_NUM_TC,
> > -	.switch_pci_bar		= 4,
> > -	.imdio_pci_bar		= 0,
> >  	.quirk_no_xtr_irq	= true,
> >  	.ptp_caps		= &vsc9959_ptp_caps,
> >  	.mdio_bus_alloc		= vsc9959_mdio_bus_alloc,
> > @@ -1388,6 +1386,9 @@ static irqreturn_t felix_irq_handler(int irq, void *data)
> >  	return IRQ_HANDLED;
> >  }
> >  
> > +#define VSC9959_SWITCH_PCI_BAR 4
> > +#define VSC9959_IMDIO_PCI_BAR 0
> > +
> 
> I would prefer these to be declared right below
> 
> #define VSC9959_TAS_GCL_ENTRY_MAX	63
> 
> and aligned with it

Done