linux-kernel - Re: [PATCH] fs:xfs: cleanup __FUNCTION_

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20210711224651.GR664593@dread.disaster.area>
Date:   Mon, 12 Jul 2021 08:46:51 +1000
From:   Dave Chinner <david@...morbit.com>
To:     Dwaipayan Ray <dwaipayanray1@...il.com>
Cc:     djwong@...nel.org, linux-xfs@...r.kernel.org,
        linux-kernel@...r.kernel.org, lukas.bulwahn@...il.com
Subject: Re: [PATCH] fs:xfs: cleanup __FUNCTION__ usage

On Sun, Jul 11, 2021 at 02:21:53PM +0530, Dwaipayan Ray wrote:
> __FUNCTION__ exists only for backwards compatibility reasons
> with old gcc versions. Replace it with __func__.
> 
> Signed-off-by: Dwaipayan Ray <dwaipayanray1@...il.com>
> ---
>  fs/xfs/xfs_icreate_item.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/fs/xfs/xfs_icreate_item.c b/fs/xfs/xfs_icreate_item.c
> index 9b3994b9c716..017904a34c02 100644
> --- a/fs/xfs/xfs_icreate_item.c
> +++ b/fs/xfs/xfs_icreate_item.c
> @@ -201,7 +201,7 @@ xlog_recover_icreate_commit_pass2(
>  	if (length != igeo->ialloc_blks &&
>  	    length != igeo->ialloc_min_blks) {
>  		xfs_warn(log->l_mp,
> -			 "%s: unsupported chunk length", __FUNCTION__);
> +			 "%s: unsupported chunk length", __func__);
>  		return -EINVAL;
>  	}
>  
> @@ -209,7 +209,7 @@ xlog_recover_icreate_commit_pass2(
>  	if ((count >> mp->m_sb.sb_inopblog) != length) {
>  		xfs_warn(log->l_mp,
>  			 "%s: inconsistent inode count and chunk length",
> -			 __FUNCTION__);
> +			 __func__);
>  		return -EINVAL;
>  	}

Looks good.

Reviewed-by: Dave Chinner <dchinner@...hat.com>

For future reference, the subject only needs "xfs:", you can drop
the "fs:" prefix from it.

-Dave.
-- 
Dave Chinner
david@...morbit.com