[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <CA+Px+wUVsY6CYwEdfSeK+KQGmvb224hvchgnTwX0rgBzMvXfqw@mail.gmail.com>
Date: Mon, 12 Jul 2021 14:05:54 +0800
From: Tzung-Bi Shih <tzungbi@...gle.com>
To: Tinghan Shen <tinghan.shen@...iatek.com>
Cc: ohad@...ery.com, bjorn.andersson@...aro.org,
mathieu.poirier@...aro.org, robh+dt@...nel.org,
matthias.bgg@...il.com, linux-remoteproc@...r.kernel.org,
devicetree@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
linux-mediatek@...ts.infradead.org, linux-kernel@...r.kernel.org,
srv_heupstream@...iatek.com,
Project_Global_Chrome_Upstream_Group@...iatek.com
Subject: Re: [v2 1/2] dt-bindings: remoteproc: mediatek: Add binding for
mt8195 scp
On Sat, Jul 10, 2021 at 8:25 PM Tinghan Shen <tinghan.shen@...iatek.com> wrote:
> @@ -5,13 +5,15 @@ This binding provides support for ARM Cortex M4 Co-processor found on some
> Mediatek SoCs.
>
> Required properties:
> -- compatible Should be "mediatek,mt8183-scp"
> +- compatible Should be one of:
> + "mediatek,mt8183-scp"
> + "mediatek,mt8195-scp"
Just realized we forgot to add DT bindings for mediatek,mt8192-scp[1].
Could you send another patch for adding the missing property?
[1]: https://elixir.bootlin.com/linux/v5.13.1/source/drivers/remoteproc/mtk_scp.c#L879
> -- clocks Clock for co-processor (See: ../clock/clock-bindings.txt)
> -- clock-names Contains the corresponding name for the clock. This
> +- clocks Required by mt8183. Clock for co-processor (See: ../clock/clock-bindings.txt)
> +- clock-names Required by mt8183. Contains the corresponding name for the clock. This
> should be named "main".
Let's move clocks and clock-names to "Optional properties". See [2]
for your reference. I guess it doesn't need to mention which chip
needs the properties. For those chips that need the clock properties,
they won't work correctly without correct clock properties.
[2]: https://elixir.bootlin.com/linux/v5.13.1/source/Documentation/devicetree/bindings/remoteproc/ti,keystone-rproc.txt#L87
Suggested to provide a cover letter for the series next time.
nit: other patches usually use "[PATCH v2 1/2]" in the email title
instead of the one used in the mail.
Powered by blists - more mailing lists