[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <c3d4ebd5-5679-cd81-d1de-4f5f2cbe13db@gmail.com>
Date: Mon, 12 Jul 2021 16:29:16 +0800
From: Desmond Cheong Zhi Xi <desmondcheongzx@...il.com>
To: Christoph Hellwig <hch@....de>, Hillf Danton <hdanton@...a.com>
Cc: syzbot <syzbot+118992efda475c16dfb0@...kaller.appspotmail.com>,
axboe@...nel.dk, linux-block@...r.kernel.org,
linux-kernel@...r.kernel.org, syzkaller-bugs@...glegroups.com,
Miquel Raynal <miquel.raynal@...tlin.com>
Subject: Re: [syzbot] possible deadlock in loop_add
On 12/7/21 1:27 pm, Christoph Hellwig wrote:
> On Sat, Jul 10, 2021 at 09:16:38PM +0800, Hillf Danton wrote:
>> To break the lock chain, un/register blkdev without mtd_table_mutex held.
>
> Yes, Desmond Cheong Zhi Xi sent pretty much the same patch on June 18th
> (mtd: break circular locks in register_mtd_blktrans), but it did not get
> picked up.
>
I believe Miquèl was waiting for -rc1 to apply it.
But taking a closer look, although the fix for the register path is the
same, Hillf Danton's proposed patch additionally avoids inverting the
lock hierarchy on the unregister path. So I believe this new patch
should be more robust.
Best wishes,
Desmond
Powered by blists - more mailing lists