linux-kernel - Re: [PATCH] task_work: return -EBUSY when adding same work

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CA+WzARky9K+pATZb5mvOpekYa0jFsE6GQ7pR9XbZ5xoEPTgw7w@mail.gmail.com>
Date:   Mon, 12 Jul 2021 17:08:48 +0800
From:   zhenguo yao <yaozhenguo1@...il.com>
To:     Jens Axboe <axboe@...nel.dk>
Cc:     oleg@...hat.com, linux-kernel@...r.kernel.org, yaozhenguo@...com
Subject: Re: [PATCH] task_work: return -EBUSY when adding same work

OK，Got it.  My patch does not cover this situation.  It seems that
there is always dead-loop when same works are added to the list.

Jens Axboe <axboe@...nel.dk> 于2021年7月12日周一 上午10:44写道：
>
> On 7/11/21 8:13 PM, zhenguo yao wrote:
> > Yes I hit this condition.  The caller is queue_task_work in
> > arch/x86/kernel/cpu/mce/core.c.
> > It is really a BUG. I have submitted another patch to fix it:
> > https://lkml.org/lkml/2021/7/9/186.
>
> That patch seems broken, what happens if mce_kill_me is added already,
> but it isn't the first work item in the list?
>
> --
> Jens Axboe
>