linux-kernel - Re: [PATCH net-next v5] net: phy: intel-xway: Add RGMII internal delay configuration

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAFBinCCMtBxvdpkiiFbB1xvy4qhCTb-hU5VJEMQdHDDAYWq=5g@mail.gmail.com>
Date:   Mon, 12 Jul 2021 13:12:20 +0200
From:   Martin Blumenstingl <martin.blumenstingl@...glemail.com>
To:     Martin Schiller <ms@....tdt.de>
Cc:     Hauke Mehrtens <hauke@...ke-m.de>, f.fainelli@...il.com,
        andrew@...n.ch, hkallweit1@...il.com, linux@...linux.org.uk,
        davem@...emloft.net, kuba@...nel.org, netdev@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH net-next v5] net: phy: intel-xway: Add RGMII internal
 delay configuration

On Mon, Jul 12, 2021 at 9:24 AM Martin Schiller <ms@....tdt.de> wrote:
>
> This adds the possibility to configure the RGMII RX/TX clock skew via
> devicetree.
>
> Simply set phy mode to "rgmii-id", "rgmii-rxid" or "rgmii-txid" and add
> the "rx-internal-delay-ps" or "tx-internal-delay-ps" property to the
> devicetree.
>
> Furthermore, a warning is now issued if the phy mode is configured to
> "rgmii" and an internal delay is set in the phy (e.g. by pin-strapping),
> as in the dp83867 driver.
>
> Signed-off-by: Martin Schiller <ms@....tdt.de>
Thanks for this updated version!
Everything's looking good so:
Reviewed-by: Martin Blumenstingl <martin.blumenstingl@...glemail.com>