[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <CAD=FV=Wij=nih9c1Dxmh=3UFXsOvdbTHBqwXxsUa+rQfpuf4Wg@mail.gmail.com>
Date: Mon, 12 Jul 2021 08:03:53 -0700
From: Doug Anderson <dianders@...omium.org>
To: Thomas Zimmermann <tzimmermann@...e.de>
Cc: Rajeev Nandan <rajeevny@...eaurora.org>,
dri-devel <dri-devel@...ts.freedesktop.org>,
linux-arm-msm <linux-arm-msm@...r.kernel.org>,
freedreno <freedreno@...ts.freedesktop.org>,
"open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS"
<devicetree@...r.kernel.org>, LKML <linux-kernel@...r.kernel.org>,
Thierry Reding <thierry.reding@...il.com>,
Sam Ravnborg <sam@...nborg.org>,
Rob Clark <robdclark@...il.com>, Lyude Paul <lyude@...hat.com>,
Jani Nikula <jani.nikula@...el.com>,
Rob Herring <robh@...nel.org>,
Laurent Pinchart <laurent.pinchart@...asonboard.com>,
Andrzej Hajda <a.hajda@...sung.com>,
Daniel Thompson <daniel.thompson@...aro.org>,
"Kristian H. Kristensen" <hoegsberg@...omium.org>,
Abhinav Kumar <abhinavk@...eaurora.org>,
Sean Paul <seanpaul@...omium.org>,
Kalyan Thota <kalyan_t@...eaurora.org>,
Krishna Manikandan <mkrishn@...eaurora.org>,
Lee Jones <lee.jones@...aro.org>,
Jingoo Han <jingoohan1@...il.com>, linux-fbdev@...r.kernel.org
Subject: Re: [v8 1/6] drm/panel: add basic DP AUX backlight support
Hi,
On Mon, Jul 12, 2021 at 6:39 AM Doug Anderson <dianders@...omium.org> wrote:
>
> Hi,
>
> On Mon, Jul 12, 2021 at 2:41 AM Thomas Zimmermann <tzimmermann@...e.de> wrote:
> >
> > > + ret = drm_dp_dpcd_read(aux, DP_EDP_DPCD_REV, edp_dpcd,
> > > + EDP_DISPLAY_CTL_CAP_SIZE);
> >
> > This creates a cyclic dependency between drm_kms_helper-ko and drm.ko.
> > drm_panel.c is in the latter, while drm_dp_dpcd_read() in
> > drm_dp_helper.c is in the former. Please fix.
>
> Yeah, this was reported Friday and I posted a patch to try to fix it:
>
> https://lore.kernel.org/lkml/20210709152909.1.I23eb4cc5a680341e7b3e791632a635566fa5806a@changeid/
>
> I see Rajeev had some feedback on it. Once I've dug out of my weekend
> email hole I'll take a look at plan to post a v2 ASAP.
Breadcrumbs: v2 of the fix is at:
https://lore.kernel.org/lkml/20210712075933.v2.1.I23eb4cc5a680341e7b3e791632a635566fa5806a@changeid/
I'm hoping this looks OK so we can get this resolved before it trips
too many people up.
-Doug
Powered by blists - more mailing lists