linux-kernel - Re: [PATCH v3 06/12] dt-bindings: power: supply: smb347-charger: Document USB VBUS regulator

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20210712153905.GA1980362@robh.at.kernel.org>
Date:   Mon, 12 Jul 2021 09:39:05 -0600
From:   Rob Herring <robh@...nel.org>
To:     Dmitry Osipenko <digetx@...il.com>
Cc:     Thierry Reding <treding@...dia.com>,
        Jonathan Hunter <jonathanh@...dia.com>,
        Mark Brown <broonie@...nel.org>,
        Sebastian Reichel <sre@...nel.org>,
        Peter Chen <peter.chen@...nel.org>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Felipe Balbi <balbi@...nel.org>,
        David Heidelberg <david@...t.cz>, devicetree@...r.kernel.org,
        linux-pm@...r.kernel.org, linux-usb@...r.kernel.org,
        linux-kernel@...r.kernel.org, linux-tegra@...r.kernel.org
Subject: Re: [PATCH v3 06/12] dt-bindings: power: supply: smb347-charger:
 Document USB VBUS regulator

On Mon, Jul 05, 2021 at 01:54:27AM +0300, Dmitry Osipenko wrote:
> SMB347 can supply power to USB VBUS, which is required by OTG-cable
> devices that want to switch USB port into the host mode. Add USB VBUS
> regulator properties.
> 
> Signed-off-by: Dmitry Osipenko <digetx@...il.com>
> ---
>  .../power/supply/summit,smb347-charger.yaml   | 28 +++++++++++++++++++
>  .../dt-bindings/power/summit,smb347-charger.h |  4 +++
>  2 files changed, 32 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/power/supply/summit,smb347-charger.yaml b/Documentation/devicetree/bindings/power/supply/summit,smb347-charger.yaml
> index 983fc215c1e5..cd3d834f734d 100644
> --- a/Documentation/devicetree/bindings/power/supply/summit,smb347-charger.yaml
> +++ b/Documentation/devicetree/bindings/power/supply/summit,smb347-charger.yaml
> @@ -73,6 +73,24 @@ properties:
>        - 1 # SMB3XX_SOFT_TEMP_COMPENSATE_CURRENT Current compensation
>        - 2 # SMB3XX_SOFT_TEMP_COMPENSATE_VOLTAGE Voltage compensation
>  
> +  summit,inok-polarity:
> +    description: |
> +      Polarity of INOK signal indicating presence of external power supply.
> +    $ref: /schemas/types.yaml#/definitions/uint32
> +    enum:
> +      - 0 # SMB3XX_SYSOK_INOK_ACTIVE_LOW
> +      - 1 # SMB3XX_SYSOK_INOK_ACTIVE_HIGH
> +
> +  usb-vbus:
> +    $ref: "../../regulator/regulator.yaml#"
> +    type: object

       unevaluatedProperties: false

With that,

Reviewed-by: Rob Herring <robh@...nel.org>

> +
> +    properties:
> +      summit,needs-inok-toggle:
> +        type: boolean
> +        description: INOK signal is fixed and polarity needs to be toggled
> +                     in order to enable/disable output mode.
> +
>  allOf:
>    - if:
>        properties:
> @@ -134,6 +152,7 @@ examples:
>              reg = <0x7f>;
>  
>              summit,enable-charge-control = <SMB3XX_CHG_ENABLE_PIN_ACTIVE_HIGH>;
> +            summit,inok-polarity = <SMB3XX_SYSOK_INOK_ACTIVE_LOW>;
>              summit,chip-temperature-threshold-celsius = <110>;
>              summit,mains-current-limit-microamp = <2000000>;
>              summit,usb-current-limit-microamp = <500000>;
> @@ -141,6 +160,15 @@ examples:
>              summit,enable-mains-charging;
>  
>              monitored-battery = <&battery>;
> +
> +            usb-vbus {
> +                regulator-name = "usb_vbus";
> +                regulator-min-microvolt = <5000000>;
> +                regulator-max-microvolt = <5000000>;
> +                regulator-min-microamp = <750000>;
> +                regulator-max-microamp = <750000>;
> +                summit,needs-inok-toggle;
> +            };
>          };
>      };
>  
> diff --git a/include/dt-bindings/power/summit,smb347-charger.h b/include/dt-bindings/power/summit,smb347-charger.h
> index d918bf321a71..3205699b5e41 100644
> --- a/include/dt-bindings/power/summit,smb347-charger.h
> +++ b/include/dt-bindings/power/summit,smb347-charger.h
> @@ -16,4 +16,8 @@
>  #define SMB3XX_CHG_ENABLE_PIN_ACTIVE_LOW	1
>  #define SMB3XX_CHG_ENABLE_PIN_ACTIVE_HIGH	2
>  
> +/* Polarity of INOK signal */
> +#define SMB3XX_SYSOK_INOK_ACTIVE_LOW		0
> +#define SMB3XX_SYSOK_INOK_ACTIVE_HIGH		1
> +
>  #endif
> -- 
> 2.32.0
> 
>