linux-kernel - Re: [PATCH V2] scripts/spdxcheck.py: Strictly read license files in utf-8

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <87y2abr0ao.fsf@meer.lwn.net>
Date:   Mon, 12 Jul 2021 09:58:55 -0600
From:   Jonathan Corbet <corbet@....net>
To:     Nishanth Menon <nm@...com>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Thomas Gleixner <tglx@...utronix.de>
Cc:     "Ravikumar, Rahul" <r-ravikumar@...com>,
        lkml <linux-kernel@...r.kernel.org>,
        linux-spdx <linux-spdx@...r.kernel.org>,
        Nishanth Menon <nm@...com>
Subject: Re: [PATCH V2] scripts/spdxcheck.py: Strictly read license files in
 utf-8

Nishanth Menon <nm@...com> writes:

> Commit bc41a7f36469 ("LICENSES: Add the CC-BY-4.0 license")
> unfortunately introduced LICENSES/dual/CC-BY-4.0 in UTF-8 Unicode text
> While python will barf at it with:
>
> FAIL: 'ascii' codec can't decode byte 0xe2 in position 2109: ordinal not in range(128)
> Traceback (most recent call last):
>   File "scripts/spdxcheck.py", line 244, in <module>
>     spdx = read_spdxdata(repo)
>   File "scripts/spdxcheck.py", line 47, in read_spdxdata
>     for l in open(el.path).readlines():
>   File "/usr/lib/python3.6/encodings/ascii.py", line 26, in decode
>     return codecs.ascii_decode(input, self.errors)[0]
> UnicodeDecodeError: 'ascii' codec can't decode byte 0xe2 in position 2109: ordinal not in range(128)
>
> While it is indeed debatable if 'Licensor.' used in the license file
> needs unicode quotes, instead, force spdxcheck to read utf-8.
>
> Reported-by: Rahul T R <r-ravikumar@...com>
> Signed-off-by: Nishanth Menon <nm@...com>
> Reviewed-by: Thomas Gleixner <tglx@...utronix.de>

I've applied this, thanks.

jon