[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20210712172116.GA2137814@robh.at.kernel.org>
Date: Mon, 12 Jul 2021 11:21:16 -0600
From: Rob Herring <robh@...nel.org>
To: Alistair Francis <alistair@...stair23.me>
Cc: dmitry.torokhov@...il.com, linux-input@...r.kernel.org,
linux-imx@....com, kernel@...gutronix.de, pinglinux@...il.com,
tatsunosuke.tobita@...om.com, junkpainting@...il.com,
ping.cheng@...om.com, linux-kernel@...r.kernel.org,
alistair23@...il.com, devicetree@...r.kernel.org
Subject: Re: [PATCH v7 2/9] dt-bindings: touchscreen: Initial commit of
wacom,i2c
On Thu, Jul 08, 2021 at 09:58:46PM +1000, Alistair Francis wrote:
> Signed-off-by: Alistair Francis <alistair@...stair23.me>
> Cc: Rob Herring <robh+dt@...nel.org>
> Cc: devicetree@...r.kernel.org
> ---
> .../input/touchscreen/wacom,generic.yaml | 48 +++++++++++++++++++
> 1 file changed, 48 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/input/touchscreen/wacom,generic.yaml
>
> diff --git a/Documentation/devicetree/bindings/input/touchscreen/wacom,generic.yaml b/Documentation/devicetree/bindings/input/touchscreen/wacom,generic.yaml
> new file mode 100644
> index 000000000000..48c611d63bd8
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/input/touchscreen/wacom,generic.yaml
> @@ -0,0 +1,48 @@
> +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/input/touchscreen/wacom,generic.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Wacom I2C Controller
> +
> +maintainers:
> + - Alistair Francis <alistair@...stair23.me>
> +
> +allOf:
> + - $ref: touchscreen.yaml#
If you use properties from here...
> +
> +properties:
> + compatible:
> + const: wacom,i2c-30
> +
> + reg:
> + maxItems: 1
> +
> + interrupts:
> + maxItems: 1
> +
> + vdd-supply:
> + description: Power Supply
> +
> +required:
> + - compatible
> + - reg
> + - interrupts
> +
> +additionalProperties: false
then this needs to be 'unevaluatedProperties: false' instead.
> +
> +examples:
> + - |
> + #include "dt-bindings/interrupt-controller/irq.h"
> + i2c {
> + #address-cells = <1>;
> + #size-cells = <0>;
> + digitiser@9 {
> + compatible = "wacom,i2c-30";
> + reg = <0x9>;
> + interrupt-parent = <&gpio1>;
> + interrupts = <9 IRQ_TYPE_LEVEL_LOW>;
> + vdd-supply = <®_touch>;
> + };
> + };
> --
> 2.31.1
>
>
Powered by blists - more mailing lists