linux-kernel - Re: [PATCH] mm: Make copy_huge

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAHS8izP7Q8VX+kpzzEUML625aPVOJkUADFs-gnBXWF-QaeKKhA@mail.gmail.com>
Date:   Mon, 12 Jul 2021 12:32:44 -0700
From:   Mina Almasry <almasrymina@...gle.com>
To:     Mike Kravetz <mike.kravetz@...cle.com>
Cc:     "Matthew Wilcox (Oracle)" <willy@...radead.org>,
        YueHaibing <yuehaibing@...wei.com>,
        Axel Rasmussen <axelrasmussen@...gle.com>,
        Peter Xu <peterx@...hat.com>,
        Andrew Morton <akpm@...ux-foundation.org>,
        Linus Torvalds <torvalds@...ux-foundation.org>,
        linux-mm@...ck.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] mm: Make copy_huge_page() always available

On Mon, Jul 12, 2021 at 10:52 AM Mike Kravetz <mike.kravetz@...cle.com> wrote:
>
> On 7/12/21 8:32 AM, Matthew Wilcox (Oracle) wrote:
> > Rewrite copy_huge_page() and move it into mm/util.c so it's always
> > available.  Fixes an exposure of uninitialised memory on configurations
> > with HUGETLB and UFFD enabled and MIGRATION disabled.
> >
> > Fixes: 8cc5fcbb5be8 ("mm, hugetlb: fix racy resv_huge_pages underflow on UFFDIO_COPY")
> > Signed-off-by: Matthew Wilcox (Oracle) <willy@...radead.org>

Reviewed-By: Mina Almasry <almasrymina@...gle.com>

> > ---
> >  include/linux/migrate.h |  5 -----
> >  include/linux/mm.h      |  1 +
> >  mm/migrate.c            | 48 -----------------------------------------
> >  mm/util.c               | 10 +++++++++
> >  4 files changed, 11 insertions(+), 53 deletions(-)
>
> Thanks Matthew,
>
> Reviewed-by: Mike Kravetz <mike.kravetz@...cle.com>
> --
> Mike Kravetz