lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-Id: <20210712194718.20813-1-sjpark@amazon.de>
Date:   Mon, 12 Jul 2021 19:47:18 +0000
From:   SeongJae Park <sj38.park@...il.com>
To:     Shuah Khan <skhan@...uxfoundation.org>
Cc:     Brendan Higgins <brendanhiggins@...gle.com>,
        SeongJae Park <sj38.park@...il.com>, dlatypov@...gle.com,
        linux-kselftest@...r.kernel.org, kunit-dev@...glegroups.com,
        linux-kernel@...r.kernel.org, SeongJae Park <sjpark@...zon.de>
Subject: Re: [PATCH v2] kunit: tool: Assert the version requirement

From: SeongJae Park <sjpark@...zon.de>

On Mon, 12 Jul 2021 13:42:34 -0600 Shuah Khan <skhan@...uxfoundation.org> wrote:

> On 6/28/21 1:41 PM, Brendan Higgins wrote:
> > On Thu, Jun 17, 2021 at 12:46 AM SeongJae Park <sj38.park@...il.com> wrote:
> >>
> >> Commit 87c9c1631788 ("kunit: tool: add support for QEMU") on the 'next'
> >> tree adds 'from __future__ import annotations' in 'kunit_kernel.py'.
> >> Because it is supported on only >=3.7 Python, people using older Python
> >> will get below error:
> >>
> >>      Traceback (most recent call last):
> >>        File "./tools/testing/kunit/kunit.py", line 20, in <module>
> >>          import kunit_kernel
> >>        File "/home/sjpark/linux/tools/testing/kunit/kunit_kernel.py", line 9
> >>          from __future__ import annotations
> >>          ^
> >>      SyntaxError: future feature annotations is not defined
> >>
> >> This commit adds a version assertion in 'kunit.py', so that people get
> >> more explicit error message like below:
> >>
> >>      Traceback (most recent call last):
> >>        File "./tools/testing/kunit/kunit.py", line 15, in <module>
> >>          assert sys.version_info >= (3, 7), "Python version is too old"
> >>      AssertionError: Python version is too old
> >>
> >> Signed-off-by: SeongJae Park <sjpark@...zon.de>
> 
> Your from and Signed-off-by email addresses don't match.
> 
> Please resend the patch with the correction.

Sorry, my fault.  Will send fixed one as a reply to this.


Thanks,
SeongJae Park

> 
> thanks,
> -- Shuah

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ