linux-kernel - Re: [PATCH V3 2/3] dt-bindings: i2c: add attribute default-timing-adjust

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20210712205342.GA2469648@robh.at.kernel.org>
Date:   Mon, 12 Jul 2021 14:53:42 -0600
From:   Rob Herring <robh@...nel.org>
To:     kewei.xu@...iatek.com
Cc:     wsa@...-dreams.de, bbrezillon@...nel.org, matthias.bgg@...il.com,
        mark.rutland@....com, devicetree@...r.kernel.org,
        linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org,
        linux-mediatek@...ts.infradead.org, srv_heupstream@...iatek.com,
        leilk.liu@...iatek.com, qii.wang@...iatek.com,
        liguo.zhang@...iatek.com, xinping.qian@...iatek.com,
        ot_daolong.zhu@...iatek.com
Subject: Re: [PATCH V3 2/3] dt-bindings: i2c: add attribute
 default-timing-adjust

On Mon, Jun 21, 2021 at 06:39:44PM +0800, kewei.xu@...iatek.com wrote:
> From: Kewei Xu <kewei.xu@...iatek.com>
> 
> Add attribute default-timing-adjust for DT-binding document.
> 
> Fixes: be5ce0e97cc7 ("i2c: mediatek: Add i2c ac-timing adjust support")

You want to fix a kernel change with a DT change? That's not a 
compatible change (and I guess neither was the kernel change). Sounds 
like the above commit should be reverted and rethink how to add a new 
feature...

> Signed-off-by: Kewei Xu <kewei.xu@...iatek.com>
> ---
>  Documentation/devicetree/bindings/i2c/i2c-mt65xx.txt | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/i2c/i2c-mt65xx.txt b/Documentation/devicetree/bindings/i2c/i2c-mt65xx.txt
> index 7c4915bc..7b80a11 100644
> --- a/Documentation/devicetree/bindings/i2c/i2c-mt65xx.txt
> +++ b/Documentation/devicetree/bindings/i2c/i2c-mt65xx.txt
> @@ -33,6 +33,8 @@ Optional properties:
>    - mediatek,have-pmic: platform can control i2c form special pmic side.
>      Only mt6589 and mt8135 support this feature.
>    - mediatek,use-push-pull: IO config use push-pull mode.
> +  - mediatek,default-timing-adjust: use default timing calculation, no timing
> +    adjustment.
>  
>  Example:
>  
> -- 
> 1.9.1
> 
>