[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20210712170934.34666a1f.alex.williamson@redhat.com>
Date: Mon, 12 Jul 2021 17:09:34 -0600
From: Alex Williamson <alex.williamson@...hat.com>
To: Amey Narkhede <ameynarkhede03@...il.com>
Cc: Bjorn Helgaas <bhelgaas@...gle.com>,
Raphael Norwitz <raphael.norwitz@...anix.com>,
linux-pci@...r.kernel.org, linux-kernel@...r.kernel.org,
kw@...ux.com, Shanker Donthineni <sdonthineni@...dia.com>,
Sinan Kaya <okaya@...nel.org>, Len Brown <lenb@...nel.org>,
"Rafael J . Wysocki" <rjw@...ysocki.net>
Subject: Re: [PATCH v10 6/8] PCI: Setup ACPI fwnode early and at the same
time with OF
On Fri, 9 Jul 2021 18:08:11 +0530
Amey Narkhede <ameynarkhede03@...il.com> wrote:
> From: Shanker Donthineni <sdonthineni@...dia.com>
>
> The pci_dev objects are created through two mechanisms 1) during PCI
> bus scan and 2) from I/O Virtualization. The fwnode in pci_dev object
> is being set at different places depends on the type of firmware used,
> device creation mechanism, and acpi_pci_bridge_d3() WAR.
>
> The software features which have a dependency on ACPI fwnode properties
> and need to be handled before device_add() will not work. One use case,
> the software has to check the existence of _RST method to support ACPI
> based reset method.
>
> This patch does the two changes in order to provide fwnode consistently.
> - Set ACPI and OF fwnodes from pci_setup_device().
> - Remove pci_set_acpi_fwnode() in acpi_pci_bridge_d3().
>
> After this patch, ACPI/OF firmware properties are visible at the same
> time during the early stage of pci_dev setup. And also call sites should
> be able to use firmware agnostic functions device_property_xxx() for the
> early PCI quirks in the future.
>
> Signed-off-by: Shanker Donthineni <sdonthineni@...dia.com>
> ---
> drivers/pci/pci-acpi.c | 1 -
> drivers/pci/probe.c | 7 ++++---
> 2 files changed, 4 insertions(+), 4 deletions(-)
Looks ok to me.
Reviewed-by: Alex Williamson <alex.williamson@...hat.com>
Powered by blists - more mailing lists