linux-kernel - [PATCH] LSM: add NULL check for kcalloc()

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <20210712234434.GA29205@raspberrypi>
Date:   Tue, 13 Jul 2021 00:44:34 +0100
From:   Austin Kim <austindh.kim@...il.com>
To:     jmorris@...ei.org, serge@...lyn.com, keescook@...omium.org
Cc:     linux-security-module@...r.kernel.org,
        linux-kernel@...r.kernel.org, austin.kim@....com,
        kernel-team@....com, austindh.kim@...il.com
Subject: [PATCH] LSM: add NULL check for kcalloc()

From: Austin Kim <austin.kim@....com>

kcalloc() may return NULL when memory allocation fails.
So it is necessary to add NULL check after the call to kcalloc() is made.

Signed-off-by: Austin Kim <austin.kim@....com>
---
 security/security.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/security/security.c b/security/security.c
index 09533cbb7221..f885c9e9bc35 100644
--- a/security/security.c
+++ b/security/security.c
@@ -321,6 +321,8 @@ static void __init ordered_lsm_init(void)
 
 	ordered_lsms = kcalloc(LSM_COUNT + 1, sizeof(*ordered_lsms),
 				GFP_KERNEL);
+	if (ordered_lsms)
+		return;
 
 	if (chosen_lsm_order) {
 		if (chosen_major_lsm) {
-- 
2.20.1