linux-kernel - Re: [PATCH v7 5/5] dt-bindings: soc: qcom: spm: Document SDM660 and MSM8998 compatibles

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20210713222111.GA944952@robh.at.kernel.org>
Date:   Tue, 13 Jul 2021 16:21:11 -0600
From:   Rob Herring <robh@...nel.org>
To:     AngeloGioacchino Del Regno 
        <angelogioacchino.delregno@...ainline.org>
Cc:     bjorn.andersson@...aro.org, agross@...nel.org,
        daniel.lezcano@...aro.org, rjw@...ysocki.net,
        linux-kernel@...r.kernel.org, linux-pm@...r.kernel.org,
        linux-arm-msm@...r.kernel.org, phone-devel@...r.kernel.org,
        konrad.dybcio@...ainline.org, marijn.suijten@...ainline.org,
        martin.botka@...ainline.org, jeffrey.l.hugo@...il.com,
        jami.kettunen@...ainline.org,
        ~postmarketos/upstreaming@...ts.sr.ht, devicetree@...r.kernel.org,
        stephan@...hold.net
Subject: Re: [PATCH v7 5/5] dt-bindings: soc: qcom: spm: Document SDM660 and
 MSM8998 compatibles

On Tue, Jun 22, 2021 at 04:11:17PM +0200, AngeloGioacchino Del Regno wrote:
> The driver was updated to add SAW2 v4.1 support for new SoCs: document
> the new compatibles.

Can't take patches without a S-o-b. Run checkpatch.pl, it points this 
out for you.

> ---
>  .../bindings/soc/qcom/qcom,spm.yaml           | 21 +++++++++++++++++++
>  1 file changed, 21 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/soc/qcom/qcom,spm.yaml b/Documentation/devicetree/bindings/soc/qcom/qcom,spm.yaml
> index 4aaa319b2932..0faf52700dec 100644
> --- a/Documentation/devicetree/bindings/soc/qcom/qcom,spm.yaml
> +++ b/Documentation/devicetree/bindings/soc/qcom/qcom,spm.yaml
> @@ -17,6 +17,10 @@ description: |
>  properties:
>    compatible:
>      enum:
> +      - qcom,sdm660-gold-saw2-v4.1-l2
> +      - qcom,sdm660-silver-saw2-v4.1-l2
> +      - qcom,msm8998-gold-saw2-v4.1-l2
> +      - qcom,msm8998-silver-saw2-v4.1-l2

What's the difference between gold and silver? Are the h/w instances 
different (I realize the CPUs are) in some way? How does the OS use the 
different compatible strings?

>        - qcom,msm8974-saw2-v2.1-cpu
>        - qcom,apq8084-saw2-v2.1-cpu
>        - qcom,apq8064-saw2-v1.1-cpu
> @@ -33,6 +37,8 @@ additionalProperties: false
>  
>  examples:
>    - |
> +
> +    /* Example 1: SoC using SAW2 and kpss-acc-v2 CPUIdle */
>      cpus {
>          #address-cells = <1>;
>          #size-cells = <0>;
> @@ -52,4 +58,19 @@ examples:
>          reg = <0xf9089000 0x1000>;
>      };
>  
> +  - |
> +
> +    /* Example 2: New-gen multi cluster SoC using SAW only for L2;
> +     * This does not require any cpuidle driver, nor any cpu phandle.
> +     */
> +    power-controller@...12000 {
> +        compatible = "qcom,msm8998-gold-saw2-v4.1-l2", "qcom,saw2";
> +        reg = <0x17812000 0x1000>;
> +    };
> +
> +    power-controller@...12000 {
> +        compatible = "qcom,msm8998-silver-saw2-v4.1-l2", "qcom,saw2";
> +        reg = <0x17912000 0x1000>;
> +    };
> +
>  ...
> -- 
> 2.32.0
> 
>