linux-kernel - Re: [PATCH V5 1/1] misc: NOC Probe Counters

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <YO05g5JiOcF/bFza@kroah.com>
Date:   Tue, 13 Jul 2021 08:58:11 +0200
From:   Greg KH <gregkh@...uxfoundation.org>
To:     pandith.n@...el.com
Cc:     arnd@...db.de, linux-kernel@...r.kernel.org, furong.zhou@...el.com,
        mgross@...ux.intel.com, mallikarjunappa.sangannavar@...el.com,
        andriy.shevchenko@...ux.intel.com,
        lakshmi.bai.raja.subramanian@...el.com
Subject: Re: [PATCH V5 1/1] misc: NOC Probe Counters

On Tue, Jul 13, 2021 at 12:23:47PM +0530, pandith.n@...el.com wrote:
> --- /dev/null
> +++ b/drivers/misc/noc/Kconfig
> @@ -0,0 +1,16 @@
> +# Copyright (C) 2019 Intel Corporation
> +# SPDX-License-Identifier: GPL-2.0-only
> +
> +
> +config NOC_DSS
> +	tristate "Enable DSS NOC probing"

Please be more descriptive of what exactly this is, it does not make
sense to anyone who does not know what DSS or NOC means.

> +	depends on ARCH_KEEMBAY
> +	default y

You only use 'y' if the machine can not boot without the option.
Otherwise it is left alone.

And what about CONFIG_TEST ability to test build this code?  Without
that, you will get almost no one every building this code to see if
anything breaks over time.

thanks,

greg k-h