linux-kernel - Re: [PATCH v3] scripts/setlocalversion: fix a bug when LOCALVERSION is empty

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <87r1g2h92y.fsf@ungleich.ch>
Date:   Tue, 13 Jul 2021 11:11:33 +0200
From:   Nico Schottelius <nico.schottelius@...leich.ch>
To:     Mikulas Patocka <mpatocka@...hat.com>
Cc:     Nico Schottelius <nico-linuxsetlocalversion@...ottelius.org>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Masahiro Yamada <masahiroy@...nel.org>,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH v3] scripts/setlocalversion: fix a bug when LOCALVERSION
 is empty



Mikulas Patocka <mpatocka@...hat.com> writes:
> I set LOCALVERSION to an empty string (with "export LOCALVERSION="). This
> prevented the kernel from adding a "+" sign to the kernel version. Since
> the commit 042da426f8eb, it no longer works and the kernel adds a "+" sign
> if LOCALVERSION is set and empty.
>
> If you don't like "if [ "${LOCALVERSION+set}" != "set" ]", then please
> provide some other way how to test if the variable is set.

I fail to see the problem you are solving, as that case works exactly
like I wrote in my last mail:

[11:09:03] nb3:~$ export LOCALVERSION=; [ -z "${LOCALVERSION}" ] && echo unset
unset
[11:09:27] nb3:~$ echo $BASH_VERSION
5.1.8(1)-release

Did you try that in your environment?


--
Sustainable and modern Infrastructures by ungleich.ch