linux-kernel - Re: [PATCH v15 09/12] dmaengine: imx-sdma: remove ERR009165 on i.mx6ul

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 13 Jul 2021 12:36:43 +0200
From:   Lucas Stach <l.stach@...gutronix.de>
To:     Robin Gong <yibin.gong@....com>, vkoul@...nel.org,
        mark.rutland@....com, broonie@...nel.org, robh+dt@...nel.org,
        catalin.marinas@....com, will.deacon@....com, shawnguo@...nel.org,
        festevam@...il.com, s.hauer@...gutronix.de,
        martin.fuzzey@...wbird.group, u.kleine-koenig@...gutronix.de,
        dan.j.williams@...el.com, matthias.schiffer@...tq-group.com,
        frieder.schrempf@...tron.de, m.felsch@...gutronix.de,
        xiaoning.wang@....com
Cc:     devicetree@...r.kernel.org, linux-kernel@...r.kernel.org,
        linux-spi@...r.kernel.org, linux-imx@....com,
        kernel@...gutronix.de, dmaengine@...r.kernel.org,
        linux-arm-kernel@...ts.infradead.org
Subject: Re: [PATCH v15 09/12] dmaengine: imx-sdma: remove ERR009165 on
 i.mx6ul

Am Mittwoch, dem 14.07.2021 um 02:41 +0800 schrieb Robin Gong:
> ECSPI issue fixed from i.mx6ul at hardware level, no need
> ERR009165 anymore on those chips such as i.mx8mq.
> 
> Signed-off-by: Robin Gong <yibin.gong@....com>
> Acked-by: Vinod Koul <vkoul@...nel.org>
> ---
>  drivers/dma/imx-sdma.c | 27 +++++++++++++++++++++++++--
>  1 file changed, 25 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/dma/imx-sdma.c b/drivers/dma/imx-sdma.c
> index 4cb2e84..211299f 100644
> --- a/drivers/dma/imx-sdma.c
> +++ b/drivers/dma/imx-sdma.c
> @@ -476,6 +476,13 @@ struct sdma_driver_data {
>  	int num_events;
>  	struct sdma_script_start_addrs	*script_addrs;
>  	bool check_ratio;
> +	/*
> +	 * ecspi ERR009165 fixed should be done in sdma script
> +	 * and it has been fixed in soc from i.mx6ul.
> +	 * please get more information from the below link:
> +	 * https://www.nxp.com/docs/en/errata/IMX6DQCE.pdf
> +	 */
> +	bool ecspi_fixed;
>  };
>  
>  struct sdma_engine {
> @@ -596,6 +603,13 @@ static struct sdma_driver_data sdma_imx6q = {
>  	.script_addrs = &sdma_script_imx6q,
>  };
>  
> +static struct sdma_driver_data sdma_imx6ul = {
> +	.chnenbl0 = SDMA_CHNENBL0_IMX35,
> +	.num_events = 48,
> +	.script_addrs = &sdma_script_imx6q,
> +	.ecspi_fixed = true,
> +};
> +
>  static struct sdma_script_start_addrs sdma_script_imx7d = {
>  	.ap_2_ap_addr = 644,
>  	.uart_2_mcu_addr = 819,
> @@ -629,6 +643,7 @@ static const struct of_device_id sdma_dt_ids[] = {
>  	{ .compatible = "fsl,imx31-sdma", .data = &sdma_imx31, },
>  	{ .compatible = "fsl,imx25-sdma", .data = &sdma_imx25, },
>  	{ .compatible = "fsl,imx7d-sdma", .data = &sdma_imx7d, },
> +	{ .compatible = "fsl,imx6ul-sdma", .data = &sdma_imx6ul, },
>  	{ .compatible = "fsl,imx8mq-sdma", .data = &sdma_imx8mq, },
>  	{ /* sentinel */ }
>  };
> @@ -947,8 +962,16 @@ static void sdma_get_pc(struct sdma_channel *sdmac,
>  		break;
>  	case IMX_DMATYPE_CSPI:
>  		per_2_emi = sdma->script_addrs->app_2_mcu_addr;
> -		emi_2_per = sdma->script_addrs->mcu_2_ecspi_addr;
> -		sdmac->is_ram_script = true;
> +
> +		/* Use rom script mcu_2_app if ERR009165 fixed */
> +		if (sdmac->sdma->drvdata->ecspi_fixed) {
> +			emi_2_per = sdma->script_addrs->mcu_2_app_addr;
> +			sdmac->is_ram_script = false;

This second line in this clause isn't needed. Please just move this
"sdmac->is_ram_script = false;" to the top of this function, so it's
easy to see that this is the default value.

Regards,
Lucas

> +		} else {
> +			emi_2_per = sdma->script_addrs->mcu_2_ecspi_addr;
> +			sdmac->is_ram_script = true;
> +		}
> +
>  		break;
>  	case IMX_DMATYPE_EXT:
>  	case IMX_DMATYPE_SSI: