linux-kernel - Re: [Intel-wired-lan] [PATCH 2/2] igc: wait for the MAC copy when enabled MAC passthrough

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1a539d4d-10b4-5b9b-31e7-6aec57120356@canonical.com>
Date:   Tue, 13 Jul 2021 21:45:10 +0800
From:   Aaron Ma <aaron.ma@...onical.com>
To:     "Neftin, Sasha" <sasha.neftin@...el.com>,
        jesse.brandeburg@...el.com, anthony.l.nguyen@...el.com,
        davem@...emloft.net, kuba@...nel.org,
        intel-wired-lan@...ts.osuosl.org, netdev@...r.kernel.org,
        linux-kernel@...r.kernel.org,
        "Edri, Michael" <michael.edri@...el.com>,
        "Ruinskiy, Dima" <dima.ruinskiy@...el.com>,
        "Shalev, Avi" <avi.shalev@...el.com>
Subject: Re: [Intel-wired-lan] [PATCH 2/2] igc: wait for the MAC copy when
 enabled MAC passthrough


On 7/8/21 12:24 PM, Neftin, Sasha wrote:
> I would to like suggest checking the following direction:
> 1. principal question: can we update the netdev device address after it is already set during probe? I meant perform another:
> memcpy(netdev->dev_addr, hw->mac.addr, netdev->addr_len) up to demand

Updating MAC addr may work.
Even at the end of probe, it still got the wrong MAC address, delay is still needed.

Aaron

> 2. We need to work with Intel's firmware engineer/group and define the message/event: MAC addressis changed and should be updated.
> As I know MNG FW updates shadow registers. Since shadow registers are different from RAL/RAH registers - it could be a notification that the MAC address changed. Let's check it.